Fix SampleData module #7287
Merged
Fix SampleData module #7287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix regression introduced in d3f49ed (BUG: Make more strings translatable) and restore the passing of the following tests: * py_Slicer4Minute * py_ShaderProperties * py_RSNA2012ProstateDemo * py_VolumeRenderingSceneClose * py_SubjectHierarchyGenericSelfTest * py_SlicerRestoreSceneViewCrashIssue3445 * py_RSNAVisTutorial * py_JRC2013Vis * py_AtlasTests
Fix regression introduced in d3f49ed (BUG: Make more strings translatable) where the builtIn category was renamed from "BuiltIn" to "General"
pieper
approved these changes
Oct 17, 2023
Thanks for the review. The change from |
Ah, yes, I see, thanks. |
|
After the integration of this PR, we are now left with one failing test 👌
|
|
Great! I'll take a quick look at this last test. |
Thanks for helping with this 🙏 The following issue report should help understand how to fix the "problem": |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the passing of the following tests addressing regressions introduced in d3f49ed (BUG: Make more strings translatable) introduced through:
Tests fixed:
py_Slicer4Minutepy_ShaderPropertiespy_RSNA2012ProstateDemopy_VolumeRenderingSceneClosepy_SubjectHierarchyGenericSelfTestpy_SampleDatapy_SlicerRestoreSceneViewCrashIssue3445py_RSNAVisTutorialpy_JRC2013Vispy_AtlasTestsTested on a local build generated on Ubuntu 20.04