Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Use main project version for macOS short version string in bundle #7271

Merged
merged 1 commit into from Oct 10, 2023

Conversation

sjh26
Copy link
Contributor

@sjh26 sjh26 commented Oct 10, 2023

This ensures that the custom application version number is used to the macOS 'Quick Look' feature

Follow on fix to: d004e4e for another version string that was missed in the initial fix.

Example of the bug:

Screenshot 2023-10-10 10 17 21

This ensures that the custom application version number is used to the
macOS 'Quick Look' feature

Follow on fix to: Slicer@d004e4e
for another version string that was missed in the initial fix
@sjh26 sjh26 requested review from pieper and lassoan October 10, 2023 14:42
@sjh26 sjh26 self-assigned this Oct 10, 2023
@sjh26 sjh26 enabled auto-merge (rebase) October 10, 2023 14:43
Copy link
Member

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@sjh26 sjh26 merged commit 01dec20 into Slicer:main Oct 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants