BUG: Update VTK to fix segfault when enabling volume rendering #7286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up of Slicer/VTK@3e45140d5 (BUG: use alpha to calculate RGBA lighting) introduced through 57b8434 (BUG: Update VTK to fix RGBA volume rendering). It removes the use of regex leading to segfault in binary compiled using gcc 7.3.1 and introduces an ivar called lightingComponent set based on the value of "independentComponents" See Slicer#7281 List of VTK changes: $ git shortlog 3e45140d5..97965bba9 --no-merges Jean-Christophe Fillion-Robin (1): BUG: Fix generation of volume rendering shader Co-authored-by: Andras Lasso <lasso@queensu.ca> Co-authored-by: Sam Horvath <sam.horvath@kitware.com> Co-authored-by: Steve Pieper <pieper@isomics.com>
pieper
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of Slicer/VTK@3e45140d5 (BUG: use alpha to calculate RGBA lighting)
introduced through 57b8434 (BUG: Update VTK to fix RGBA volume rendering).
It removes the use of regex leading to segfault in binary compiled using gcc 7.3.1 and introduces an ivar called lightingComponent set based on the value of "independentComponents"
See #7281
List of VTK changes:
References: