BUG: Fix nodes not getting removed in vtkMRMLSequenceNode::SetDataNodeAtValue #7335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassoan
previously approved these changes
Nov 7, 2023
…eAtValue When SetDataNodeAtValue is called, the new data node is deep-copied into the internal sequence scene, and replaces the old node in the index list if one exists. The old node however is not removed from the scene, causing the number of nodes to grow larger every time SetDataNodeAtValue was called for a value with an existing data node. Fixed by removing the old node from the scene if one already exists for the specified value. This commit also changes the node pointer in IndexEntryType to a vtkWeakPointer. Fixes Slicer#7328
…de scene Adds additional tests to vtkMRMLSequenceNodeTest1 to check internal scene behavior. Check that nodes are correctly added and removed from the internal scene in vtkMRMLSequenceNode.
Sunderlandkyl
force-pushed
the
seq_set_data_node_remove_node
branch
from
61036e0
to
280625b
Compare
|
Added new tests in 280625b. |
jcfr
added
the
backport:5.x
jcfr
removed
the
backport:5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SetDataNodeAtValue is called, the new data node is deep-copied into the internal sequence scene, and replaces the old node in the index list if one exists. The old node however is not removed from the scene, causing the number of nodes to grow larger every time SetDataNodeAtValue was called for a value with an existing data node.
Fixed by removing the old node from the scene if one already exists for the specified value. This commit also changes the node pointer in IndexEntryType to a vtkWeakPointer.
Fixes #7328