Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix nodes not getting removed in vtkMRMLSequenceNode::SetDataNodeAtValue #7335

Merged
merged 2 commits into from Nov 7, 2023
Merged

BUG: Fix nodes not getting removed in vtkMRMLSequenceNode::SetDataNodeAtValue #7335

merged 2 commits into from Nov 7, 2023

Commits on Nov 7, 2023

  1. BUG: Fix nodes not getting removed in vtkMRMLSequenceNode::SetDataNod… 

    …eAtValue

When SetDataNodeAtValue is called, the new data node is deep-copied into the internal sequence scene, and replaces the old node in the index list if one exists. The old node however is not removed from the scene, causing the number of nodes to grow larger every time SetDataNodeAtValue was called for a value with an existing data node.

Fixed by removing the old node from the scene if one already exists for the specified value.
This commit also changes the node pointer in IndexEntryType to a vtkWeakPointer.

Fixes Slicer#7328
    @Sunderlandkyl
    Sunderlandkyl committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    cbcd720 View commit details
    Browse the repository at this point in the history

  2. ENH: Add additional test for node count in internal vtkMRMLSequenceNo… 

    …de scene

Adds additional tests to vtkMRMLSequenceNodeTest1 to check internal scene behavior.
Check that nodes are correctly added and removed from the internal scene in vtkMRMLSequenceNode.
    @Sunderlandkyl
    Sunderlandkyl committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    280625b View commit details
    Browse the repository at this point in the history