Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Clarify steps for installing Qt in windows build instructions #7388

Closed
wants to merge 1 commit into from

Conversation

ungi
Copy link
Contributor

@ungi ungi commented Nov 14, 2023

This clarifies instructions describing how to use Qt universal installer.

sjh26

This comment was marked as outdated.

@ungi

This comment was marked as outdated.

@sjh26
Copy link
Contributor

sjh26 commented Nov 14, 2023

Looks, good, you just need to add the DOC: prefix to your commit message

Oh, I forgot about that. Amending the commit message would require a force push, I think. Maybe I will delete this one and create a new one. OK?

That's fine

@ungi ungi closed this Nov 14, 2023
@jcfr jcfr reopened this Nov 14, 2023
This clarifies instructions describing how to use Qt universal
installer.
@jcfr jcfr changed the title Update windows.md DOC: Clarify steps for installing Qt in windows build instructions Nov 14, 2023
@jcfr
Copy link
Member

jcfr commented Nov 14, 2023

create a new one. OK?

@ungi In the interest of time, the current pull-request has been re-opened and updated.

@jcfr jcfr requested a review from sjh26 November 14, 2023 18:48
@jcfr
Copy link
Member

jcfr commented Nov 14, 2023

Since the readthedocs build failed to be triggered (likely due to the closing/re-opening), we are closing it. Superseded by #7389

@jcfr jcfr closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants