Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] ENH: Make Tables module translatable (SlicerLanguagePacks#12) #7459

Merged
merged 2 commits into from Dec 11, 2023

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Dec 11, 2023

Backports changes originally contributed to main through the following pull requests:

lassoan and others added 2 commits December 11, 2023 13:37
Table column name (non-translatable) and title (displayed, translatable) can now be set separately.
This allows displaying tables in any language while allowing modules to retrieve columns of tables using language-independent string identifiers.

Updated Segment Statistics module to make all plugins and measurements translatable.

To reduce complexity of the Tables module API, column "title" has replaced "long name". Long name was barely used (if at all) and its role would have been unclear (since we have name, title, description columns already).
Improved appearance of table column tooltips (reordered, improved formatting, added display of all custom properties)., use acronym of plugin instead of (1), (2), ... for distinguishing columns that would have had the same name.

see Slicer#7217

(cherry picked from commit d369841)
@jcfr jcfr requested a review from lassoan December 11, 2023 18:42
@jcfr jcfr mentioned this pull request Dec 11, 2023
18 tasks
@jcfr jcfr enabled auto-merge (rebase) December 11, 2023 21:53
@jcfr jcfr merged commit 59b85d5 into Slicer:5.6 Dec 11, 2023
6 checks passed
@jcfr jcfr deleted the 5.6-backport/table-module-internationalization branch December 11, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants