Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] BUG: Fix temporary folder containing special characters #7460

Merged
merged 1 commit into from Dec 11, 2023

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Dec 11, 2023

Backports changes originally contributed to main through the following pull requests:


qt.QDateTime().currentDateTime().toString(...) may use Arabic numerals on an operating system set to Arabic language. Always specify en-US locale when using when using date in file/folder names to avoid having to work with paths that may contain unicode characters (such paths may cause problems on certain file systems and it may not be always possible to pass them as command-line arguments).

Fixes problem originally reported at:
https://discourse.slicer.org/t/i-tried-everything-to-run-totalsegmentator-pls-help/33023/3

(cherry picked from commit eccb98c)

qt.QDateTime().currentDateTime().toString(...) may use Arabic numerals on an operating system set to Arabic language.
Always specify en-US locale when using when using date in file/folder names to avoid having to work with paths that may contain unicode characters
(such paths may cause problems on certain file systems and it may not be always possible to pass them as command-line arguments).

Fixes problem originally reported at:
https://discourse.slicer.org/t/i-tried-everything-to-run-totalsegmentator-pls-help/33023/3

(cherry picked from commit eccb98c)
@jcfr jcfr requested a review from lassoan December 11, 2023 18:45
@jcfr jcfr mentioned this pull request Dec 11, 2023
18 tasks
@jcfr jcfr enabled auto-merge (rebase) December 11, 2023 21:55
Copy link
Contributor

@sjh26 sjh26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jcfr jcfr merged commit 38e54b9 into Slicer:5.6 Dec 11, 2023
6 checks passed
@jcfr jcfr deleted the 5.6-backport/fix-arabic-numerals branch December 11, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants