Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] BUG: Fix vtkQtTranslator leak on quick exit #7465

Merged

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Dec 11, 2023

Backports changes originally contributed to main through the following pull requests:


Fix a regression introduced in db1d601 (BUG: Enable language translation in MRML classes) ensuring the vtkQtTranslator instance is deleted in quickExit

(cherry picked from commit 3f0e381)

Fix a regression introduced in db1d601 (BUG: Enable language translation
in MRML classes) ensuring the vtkQtTranslator instance is deleted in quickExit

(cherry picked from commit 3f0e381)
@jcfr jcfr requested a review from lassoan December 11, 2023 20:08
@jcfr jcfr enabled auto-merge (rebase) December 11, 2023 21:53
Copy link
Contributor

@sjh26 sjh26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jcfr jcfr merged commit c1c9e0b into Slicer:5.6 Dec 11, 2023
5 checks passed
@jcfr jcfr deleted the 5.6-backport/fix-vtkQtTranslator-leak-on-quickexit branch December 11, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants