ENH: Update VTK to latest master (WIP) #1252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 8, 2019 10:14
Tried to update renamed CMake options.
…90.lib It was a recent regression in VTK. Fixed by updating to latest VTK.
lassoan
force-pushed
the
build-with-vtk89
branch
from
b9f1ef5
to
82e4379
Compare
lassoan
force-pushed
the
build-with-vtk89
branch
from
82e4379
to
da8f2d1
Compare
|
Branch that fixes the CTK error about not finding python36.lib |
Closed
|
Superseded by Slicer/Slicer#1312 |
Should we close this PR then? Note that since the lassoan:build-with-vtk89 branch is in a pull request, you can push to this branch in my fork directly. So, you can you don't have to create a new PR just to be able to push changes. Of course, if you prefer to create a new PR for any other reason, then I'm OK with it. |
4 tasks
|
Closing. This branch was superseded by #1312 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress, just created the pull request to give better visibility and allow all maintainers to make changes directly in this branch.