Build with vtk89

[cpinter]

This branch is the continuation of the work of @lassoan in PR Slicer/Slicer#1252

Python wrapping of VTK classes seems to work. The remaining errors on Windows are:

"c:\e\ScD\Slicer-build\ALL_BUILD.vcxproj" (default target) (1) ->
"C:\e\ScD\Slicer-build\E\DataStore\DataStore\Testing\Cxx\qSlicerDataStoreModuleCxxTests.vcxproj" (default target) (290) ->
(ClCompile target) ->
  C:\e\ScD\Slicer-build\E\DataStore\DataStore\Testing\Cxx\qSlicerDataStoreModuleCxxTests.cxx(139): error C2039: 'SendToStdErrOn': is not a member of 'vtkWin32OutputWindow' [C:\e\ScD\Slicer-build\E\DataStore\DataStore\Testing\Cxx\qSlicerDataStoreModuleCxxTests.vcxproj]


"c:\e\ScD\Slicer-build\ALL_BUILD.vcxproj" (default target) (1) ->
"C:\e\ScD\Slicer-build\Modules\Loadable\Segmentations\Logic\vtkSlicerSegmentationsModuleLogicPython.vcxproj" (default target) (518) ->
"C:\e\ScD\Slicer-build\Modules\Loadable\Segmentations\Logic\vtkSlicerSegmentationsModuleLogicPythonD.vcxproj" (default target) (519) ->
  C:\e\ScD\Slicer-build\Modules\Loadable\Segmentations\Logic\vtkImageGrowCutSegmentPython.cxx(195): error C2280: 'vtkImageGrowCutSegment::vtkImageGrowCutSegment(const vtkImageGrowCutSegment &)': attempting to reference a deleted function [C:\e\ScD\Slicer-build\Modules\Loadable\Segmentations\Logic\vtkSlicerSegmentationsModuleLogicPythonD.vcxproj]

The first error should not happen, as the precompiler directive of
#if VTK_MAJOR_VERSION >= 9 || (VTK_MAJOR_VERSION >= 8 && VTK_MINOR_VERSION >= 90)
should work (see line in question in generated file here). Maybe the VTK version variables are not propagated to the project. correctly

In the case of the second error, the python wrapping C++ file is quite different. In the current Slicer master, vtkImageGrowCutSegmentPython.cxx does not contain a PyvtkImageGrowCutSegment_vtkImageGrowCutSegment ragular constructor, but a VTK constructor PyvtkImageGrowCutSegment_NewInstance instead. It is possible that the class is not wrapped as a VTK class.

[cpinter]

One more thing: Slicer.exe is built, but on launch I'm getting this:

[lassoan]

Does python37.dll exist? Do you see more information if you start from the debugger? Do you see any additional information in Windows event log?

[jcfr]

python37.dll

Slicer is expected to link against python36. See https://github.com/Slicer/Slicer/blob/ba6e736fba521d4a5d653af03b204add643f793a/SuperBuild/External_python.cmake#L60

@cpinter During the project week, did we find out the root cause of this ?

[jcfr]

Looks like the changes requiring Python3_* variables to be passed are missing. When I land, I will check if these changes where done on my other laptop.

[jcfr]

Looks like the changes requiring Python3_* variables to be passed are missing. When I land, I will check if these changes where done on my other laptop.

[pieper]

Let me know if/when you'd like me to try a mac build.

[cpinter]

Sorry for the delay... I'm back now.

@jcfr Have you had time to check on your other laptop regarding passing the Python3_* variables?

[jcfr]

Have you had time to check on your other laptop regarding passing the Python3_* variables?

Sadly, I can't find the changes on my laptop.

[cpinter]

Thanks for the info, @jcfr!

If anyone has an idea about how to address any of the three issues (1. wrong VTK version in ifdef, 2. wrong python wrapping of VTK class, 3. python37.dll issue), feel free to issue a new PR or just comment here. I'll work on other things now, but can test ideas using my build.

[lassoan]

The first error should not happen, as the precompiler directive of
#if VTK_MAJOR_VERSION >= 9 || (VTK_MAJOR_VERSION >= 8 && VTK_MINOR_VERSION >= 90)
should work (see line in question in generated file here). Maybe the VTK version variables are not propagated to the project. correctly

You need to add:

#include <vtkVersion.h> // must precede reference to VTK_MAJOR_VERSION

[jcfr]

Closing. This PR is superseded by Slicer/Slicer#5141