Append multiple clusters into one vtp file

[zhangfanmark]

Hi Lauren,

Please see the script for appending the clusters. It takes the input e.g. 1,2,3 and generates a 'cluster_appended_1_2_3.vtp'. The point scalar 'cluster_idx' is added to view the fibers from different subjects.

Regards,
Fan

[ljod]

Hi Fan. Thanks for writing this. Could you use the standard argparse list format for multiple arguments instead of the comma-separated no spaces string? I think this will be less error-prone for users. See first example here for nargs +:

https://docs.python.org/3/library/argparse.html

[zhangfanmark]

Hi Lauren, please see the updates. Thanks!

Regards,
Fan

[ljod]

Nice. Two thoughts:

This line is duplicated so the array is added twice
pd_cluster_point = pd_cluster.GetPointData().AddArray(vtk_array)

Also at the end please don't write patients because this will be several clusters from the same subject--perhaps the helpful printout can say something about cluster number not patient?

[zhangfanmark]

Hi Lauren,

Sorry I forgot this commit. Do you think it is okay now? Thanks!

Regards,
Fan

[ljod]

Sure it must be ok now.

On Thu, Aug 4, 2016 at 6:54 PM -0400, "zhangfanmark" <notifications@github.commailto:notifications@github.com> wrote:

Hi Lauren,

Sorry I forgot this commit. Do you think it is okay now? Thanks!

Regards,
Fan

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com//pull/48#issuecomment-237709036, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEgM973D7n_-oK-_WtJGYQgDzPzOa5chks5qcm22gaJpZM4JcFJp.

The information in this e-mail is intended only for the person to whom it is
addressed. If you believe this e-mail was sent to you in error and the e-mail
contains patient information, please contact the Partners Compliance HelpLine at
http://www.partners.org/complianceline . If the e-mail was sent to you in error
but does not contain patient information, please contact the sender and properly
dispose of the e-mail.