-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subject hierarchy problems after beam changes #128
Comments
The above screenshot was from the DICOM module's SH tree. After switching to the Data module, the following changes happened:
|
I can comment some elements about MLC: Two MLC nodes (table for positions, double array for boundary) are created and added to the scene as
The part of the code which forms hierarchy: MLC table as a child of the beam, Scan Spot Map data as a child of the ion beam, goes right after It doesn't work if i place that part before the EndState command, even when i switched to the Data module (MLC tables will remain under the root). |
Thanks, I'll look at this. It is possible we should remove batch processing, since only a few nodes are involved. However, I cannot do much as long as SlicerRT build fails, please see #129 |
Thanks! I remember that you left some of the SH stuff on us, so no rush with this. What really bothers me is the disappearing items. Maybe @Sunderlandkyl could look at this after the conference (Slicer project week starts on Monday), or me during... |
No rush at all. I thought that the mess in DICOM module's hierarchy tree was not a bug but a feature. |
Please also note, that in #124 i have slightly changed beam node naming: Of course it can be easily disabled, if it unacceptable! |
By removing batch processing, subject hierarchy item creation and parenting seems to work well. Show/hide is apparently functioning properly too. Test #128
I removed batch processing, and item creation and parenting work well. Beam visibility as well. Not sure, but I think this problem is related to the recent changes in the DICOM module, so now there is an active SH tree view during loading, and it updates itself live while the nodes and items from DICOM are being loaded. |
Some minor change in style that doesn't affect beam visualization, compared to the previous version. #136 |
In the latest version subject hierarchy appears and functions normally. |
After the recent improvements related to RT plans and beams (#120 and #122) these items in subject hierarchy behave in a wrong way.
I loaded the usual test dataset RANDO PROSTATE and got this in subject hierarchy:
Issues:
The text was updated successfully, but these errors were encountered: