diamondRequired still is breaking tool data when set to false. #131
Comments
So.. you want the diamond/emerald config option in vanilla tinkers? |
No. I personally don't want it but because you need the bronze+diamond to get obsidian. I thought that it might have been simpler to just change the config option to disable gem mining level changes and then another option to disable/enable the Bronze+diamond replacement to steel. |
I am also interested in this ^ |
..you can always use steel no matter what the config is? |
Yes. You can use steel but if you want to force people to use the tier system bronze > steel > alumite. You don't want the bronze+diamond harvest level change but if you change it it removes the harvest level edit and gem modifiers. Reasoning: It is under the "harvestleveltweaks" part of the config. The description for the option is this So someone reading this understand this:
This is what it currently will do:
What I suggest to change it to is:
OPTIONAL: "gemHarvest = true/false" Allows for just harvest level changes for diamond and emerald. |
That is incorrect. Diamond/Emerald ALWAYS give their durability and can always be obtained. The config option does not have any affect on that. |
Fresh install of Tinkers, Mantel and Tinkers tweaks nothing else. http://i.imgur.com/LaMIQb6.png Works fine. No config changes. http://i.imgur.com/0Op2PdP.png Breaks tool. Config change was B:diamondRequired=false and the removal of all other random modifiers so I got it right away. Same tool as before. I was wrong about the option disabling the diamond/emerald modifiers. (Must not of had a modifier when it happened or it wasn't working because the tool was messed up.) I still think the options would be nice to have. Thats up to you. |
What version of ITT are you using? Also the message has no actual impact on the functionality, and there are a ton of edge cases. Might be one of those, but pretty much all of them should be fixed in the last version. |
V2.1.4 And this is a major issue because if you follow the tip to put it in a crafting window it sets the harvest level to cobalt. Even on flint. |
If you take a new flint pick, add diamond/emerald, what harvest level does it have? If it's incorrect, what does the result get? Of the new pick. |
Adding the diamond manually it is fine. When it gets it randomly it breaks. |
Then something else messes with it. It doesn't matter if it's added manually or by levelup, it's exactly the same thing. |
If it was working this issue wouldn't exist. |
Well, you also haven't given me all the infos you could give me. ;P |
I don't know what else to give? Leveling the tool with that config false = broken tool. No logs are created that I found. This is still the case with just tinkers, mantel and tinkers tweaks so its not an interaction of mods doing it. I have nothing else to give. Unless you have something you want me to test. |
I believe I found the culprit. Another edge case. However you might still want to disable the harvest-levels given by diamond/emerald in the tinkers config. |
PRASE ALL THE TOOL LORDS! I will do that. (The fact that I clicked this tab and you responded was creepy) |
(Don't look behind) |
#64 is not fixed.
If you set B:diamondRequired=false it removes the ability to add diamonds/emeralds and if you get them via Auto-Level it breaks to the tool data and if you place it in a crafting window it will break the mining level. It often is boosted to cobalt mining level after trying the 'recommended' fix.
I would like to keep the durability changes without the mining level changes. Perhaps splitting the option into two one to disable mining level changes and then applying it to bronze to get diamond level?
The text was updated successfully, but these errors were encountered: