Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leg twist compenstation #7

Open
Eirenliel opened this issue Jul 13, 2021 · 2 comments
Open

Leg twist compenstation #7

Eirenliel opened this issue Jul 13, 2021 · 2 comments
Labels
Area: Skeletal Model Deals with the model of the skeleton and its pose Difficulty: Math Heavy For something that requires some non-trivial math Priority: Normal The default priority Type: Enhancement Adds or improves a feature

Comments

@Eirenliel
Copy link
Member

Some people's legs twist when they bend or twist them, like on the pictures below:

img

img

We need to add a coefficient that can be configured when the person sits, that will compensate for the twist. The coefficient should untwist the leg based on the pitch of it. The compensation should be applied to the base rotation of the tracker.

@ButterscotchV
Copy link
Member

Just coming in to document what I had previously toyed around with for this. I messed around with the skeleton data and offset the lower leg tracker rotation by a manually calibrated amount, multiplied by the bending of the knee, doing so I managed to somewhat consistently reduce the false rotation which resulted in significantly less foot sliding.

For the manually calibrated values, each leg had to have its own calibrated value, they were significantly different. The issues left to resolve for this are how it will be calibrated, whether it would need to be calibrated every time the trackers are put on, and how to compensate for the rotation of the upper leg.

@Eirenliel
Copy link
Member Author

Leg twist compensation

@TheButlah TheButlah added the Status: Unlabeled A maintainer has not yet labeled this label Oct 5, 2022
@Erimelowo Erimelowo added Type: Feature Request Difficulty: Math Heavy For something that requires some non-trivial math Area: Skeletal Model Deals with the model of the skeleton and its pose Priority: Normal The default priority and removed Status: Unlabeled A maintainer has not yet labeled this labels Oct 5, 2022
loucass003 added a commit that referenced this issue Nov 13, 2022
@TheButlah TheButlah added Type: Enhancement Adds or improves a feature and removed Type: Feature Request labels Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Skeletal Model Deals with the model of the skeleton and its pose Difficulty: Math Heavy For something that requires some non-trivial math Priority: Normal The default priority Type: Enhancement Adds or improves a feature
Development

No branches or pull requests

4 participants