Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compact IMU frame (rot+acc) #1001

Merged
merged 2 commits into from
Apr 21, 2024
Merged

Conversation

9il
Copy link
Contributor

@9il 9il commented Apr 21, 2024

No description provided.

Copy link
Member

@TheDevMinerTV TheDevMinerTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, but having an actual implementation in the official firmware would be amazing.

Copy link
Member

@TheDevMinerTV TheDevMinerTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong button

@ImUrX ImUrX added Area: Hardware Protocol Related to communication with hardware/software trackers Type: Enhancement Adds or improves a feature Area: Server Related to the server labels Apr 21, 2024
@9il
Copy link
Contributor Author

9il commented Apr 21, 2024

@TheDevMinerTV I have renamed the packet as you suggested.

| The code looks fine, but having an actual implementation in the official firmware would be amazing.

The code looks fine, but having an actual implementation in the official firmware would be amazing.

Unfortunately, our code isn't compatible with the SlimeVR firmware due to its reliance on a special slime extension of Mir Ion, a Dlang serialization library.

However, its encoding is very similar to HID after #1000. BTW, I think the quaternion order in the HID protocol is different. Will update #1000 then.

@9il 9il requested a review from TheDevMinerTV April 21, 2024 16:51
Copy link
Member

@TheDevMinerTV TheDevMinerTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eirenliel Eirenliel merged commit ae4391b into SlimeVR:main Apr 21, 2024
8 checks passed
@9il 9il deleted the IMUFrame branch April 21, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Hardware Protocol Related to communication with hardware/software trackers Area: Server Related to the server Type: Enhancement Adds or improves a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants