Better JVM detection #494
Merged
Better JVM detection #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImUrX
added
Area: GUI
|
nvm, gonna delete the profile thing. It's getting ignored 馃槶 |
Eirenliel
approved these changes
Jan 21, 2023
ImUrX
force-pushed
the
better-java-glob
branch
from
4c5e2f5
to
f8eb8fd
Compare
kitlith
approved these changes
Jan 22, 2023
TheButlah
requested changes
Jan 22, 2023
ImUrX
force-pushed
the
better-java-glob
branch
from
b0e98e8
to
8cb25b8
Compare
TheButlah
approved these changes
Jan 22, 2023
Co-authored-by: Ryan Butler <thebutlah@gmail.com>
Co-authored-by: Ryan Butler <thebutlah@gmail.com>
ImUrX
force-pushed
the
better-java-glob
branch
from
051b818
to
9619ca9
Compare
|
this is ready for merge |
TheButlah
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added conditionals depending on OS, now Linux does it's own JVM detection based on
/usr/lib/jvm.Also left a macOS one because it makes the
#[cfg()]a lot cleaner and I just need to actually test it (I know where macOS saves them but I still want to test it).I prioritized the
APPDIRenv just in case, because if we are using AppImage, we should trust the jar we have instead of a relative dir one.I also kind of crept in some optimizations on the release build for less bin size... 馃憖