Fix GUI bugs #707
Merged
Fix GUI bugs #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui/src/App.tsx
Outdated
| ).then((res) => res.json()); | ||
| ) | ||
| .then((res) => res.json()) | ||
| .then((json: Release[]) => json.filter((rl) => !rl.prerelease)); |
There was a problem hiding this comment.
It'd be smart if we were to actually validate the objects here, for example with zod.
TheDevMinerTV
requested changes
Jun 3, 2023
| document.addEventListener('keypress', onKeyboard); | ||
| return () => document.removeEventListener('keypress', onKeyboard); | ||
| document.addEventListener('keyup', onKeyboard); | ||
| return () => document.removeEventListener('keyup', onKeyboard); |
There was a problem hiding this comment.
Please just move this into a different PR...
TheDevMinerTV
requested changes
Jun 3, 2023
| ).then((res) => res.json()); | ||
| ) | ||
| .then((res) => res.json()) | ||
| .then((json: any[]) => json.filter((rl) => rl?.prerelease === false)); |
There was a problem hiding this comment.
its better than bringing a whole dependency for one type check
TheDevMinerTV
requested changes
Jun 3, 2023
Comment on lines
+153
to
+155
| __VERSION_TAG__ && | ||
| typeof releases[0].tag_name === 'string' && | ||
| semver.gt(releases[0].tag_name, __VERSION_TAG__) |
There was a problem hiding this comment.
very cursed, no thank you.
Erimelowo
approved these changes
Jun 5, 2023
Eirenliel
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curIndexbefore