Refactor of the dropdown component #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loucass003
requested review from
Erimelowo,
ImUrX and
Eirenliel
as code owners
loucass003
force-pushed
the
llelievr/dropdown-refactor
branch
from
2d1bedb
to
93f9e26
Compare
The dropdown has been redone to use portals making the different unfocus states easier to handle and also allowing for the dropdown items to go over sections with overflow hidden. Also the getValues props has been removed as it is not needed and was a wrong usage of react-form-hooks
loucass003
force-pushed
the
llelievr/dropdown-refactor
branch
from
93f9e26
to
3ce0489
Compare
ButterscotchV
added
Area: GUI
ImUrX
approved these changes
Oct 31, 2023
Erimelowo
approved these changes
Nov 3, 2023
ImUrX
approved these changes
Nov 3, 2023
ImUrX
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dropdown has been redone to use portals
making the different unfocus states easier to handle and also allowing for the dropdown items to go over sections with overflow hidden.
Also the getValues props has been removed as it is not needed and was a wrong usage of react-form-hooks