Don't set all trackers to "ok" on device reconnect #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code sets the status of disconnected trackers to "ok", this works fine if the trackers connected to the device don't change, but it absolutely can. We can instead simply rely on `setUpSensor` to set the status more accurately, as it should always be called when a device connects or re-connects, for each tracker.
ButterscotchV
added
Type: Bug
ImUrX
approved these changes
Oct 31, 2023
Erimelowo
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code sets the status of disconnected trackers to "ok", this works fine if the trackers connected to the device don't change, but it absolutely can.
We can instead simply rely on
setUpSensorto set the status more accurately, as it should always be called when a device connects or re-connects, for each tracker.Fixes #871