Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete TODO of replacing quatToXyzAngles with toEulerAngles #915

Merged
merged 3 commits into from
Jan 7, 2024

Conversation

VocalFan
Copy link
Contributor

Replaces angleBuf = quatToXyzAngles(rot.unit(), angleBuf); with EulerAngles eulerIntrinsic = rot.unit().toEulerAngles(EulerOrder.XYZ);

Since this also makes quatToXyzAngles now unused anywhere in the code, I decided to delete the unused function to save space.

Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I wanna do a quick test with it to make sure functionality is the same, but this todo has been here for a bit, good job

@ButterscotchV ButterscotchV added Priority: Normal The default priority Type: Enhancement Adds or improves a feature Area: Server Related to the server labels Dec 29, 2023
@VocalFan
Copy link
Contributor Author

Looks good, I wanna do a quick test with it to make sure functionality is the same, but this todo has been here for a bit, good job

Mhmm! Just doing what I can, not the best at Java I took like, a single class on it.

And I don't know much about the functions methods in this project.

Copy link
Member

@ImUrX ImUrX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool, hope to see you again in the future :3

@VocalFan
Copy link
Contributor Author

very cool, hope to see you again in the future :3

Rust is more my thing but uh, I don't see much in the rust repo that is beginner lol

@ImUrX
Copy link
Member

ImUrX commented Dec 29, 2023

we also have some rust in here if you want to refactor, its in gui/src-tauri

Copy link
Member

@Erimelowo Erimelowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EulerOrder must be ZXY

@Erimelowo Erimelowo merged commit aaa5c2b into SlimeVR:main Jan 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Server Related to the server Priority: Normal The default priority Type: Enhancement Adds or improves a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants