Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skeleton refactor #95

Merged
merged 19 commits into from
Dec 24, 2021
Merged

Skeleton refactor #95

merged 19 commits into from
Dec 24, 2021

Conversation

ButterscotchV
Copy link
Member

(Just as a quick warning, this has not been properly tested with trackers yet and may not be safe for a release build, proper testing is highly recommended)

  • Replaced HumanSkeletonWithWaist and HumanSkeletonWithLegs with SimpleSkeleton
  • Replaced skeleton configuration from SimpleSkeleton with a new separated SkeletonConfig class
  • Added SkeletonConfigValue, SkeletonConfigToggle, and SkeletonNodeOffset enums for skeleton configuration entries
  • Updated AutoBone's loss functions, extending functionality
  • Updated default skeleton config in accordance with Changed default body proportions #94
  • Updated all other code to be compatible with the new SimpleSkeleton and SkeletonConfig

@ButterscotchV
Add full tracker functionality to SimpleSkeleton
f49b255
@ButterscotchV
AutoBone: Scale distances by height difference
289a7f8
@ButterscotchV
AutoBone: Add offset slide error
7eec89b
@ButterscotchV
Add new config for offset slide error & disable dist scaling
e3d9eb6
@ButterscotchV
Add new SkeletonConfig class for configuring bone lengths and toggles
91c0dde
@ButterscotchV
Add more ways to set SkeletonConfig values
6816475
@ButterscotchV
Update AutoBone to use SkeletonConfig
d304975
@ButterscotchV
Use config enum instead of strings for AutoBone
40281f6
@ButterscotchV
Make SimpleSkeleton compatible with HumanSkeleton
a7cbe91
@ButterscotchV
Move skeleton namespace
473550b
@ButterscotchV
Remove other HumanSkeleton implementations
c974065
@ButterscotchV
Remove String skeleton config & fix null exception with SkeletonConfig
77fa27a
@ButterscotchV
Update config defaults from @Louka3000
43bbd4b
@ButterscotchV
Properly save SkeletonConfig values
0690d74
@ButterscotchV
Optimize offset calculation for bulk config set & finish AutoBone imp…
3f304f7 
…lementation
@ButterscotchV
Change StringBuilder.isEmpty() to length check instead for Java 8 c…
1a3a955 
…ompatibility
@ButterscotchV
Fix merge conflict
e107326
@ButterscotchV
Remove comment, this was fixed
be2c010
@ButterscotchV
Fix all config "Reset" buttons being timed
a5e4b4d
@Eirenliel Eirenliel merged commit b81458d into SlimeVR:main Dec 24, 2021
@Eirenliel Eirenliel mentioned this pull request Dec 24, 2021
Closed
@Erimelowo Erimelowo mentioned this pull request Jan 2, 2022
Closed
@ButterscotchV ButterscotchV deleted the skeleton-refactor branch February 9, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ButterscotchV @Eirenliel