Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Adds support for Aliyun OSS Storage Driver #25

Closed
wants to merge 10 commits into from

Conversation

borie88
Copy link

@borie88 borie88 commented Feb 12, 2018

Requires ali-oss npm package: npm install oli-oss --save

@RomainLanz
Copy link
Member

Wow, thank you @borie88!
Could you add some tests to your PR?

@borie88
Copy link
Author

borie88 commented Feb 13, 2018

Sure thing. Will do that ASAP

@RomainLanz
Copy link
Member

Hey @borie88!

Any news on this?

@RomainLanz
Copy link
Member

Hey @borie88! 👋

Thanks for all those updates, could you please also add some tests to your proposal?

If you could use this PR to also implement your testing env in Docker that would be awesome!

@borie88
Copy link
Author

borie88 commented Sep 20, 2018

Oops, forgot i was still updating the PR here as well. Have some refactoring to do to comform with the more recent dependency updates, and the Tencent cloud service still does not have support for getStream

@RomainLanz RomainLanz added this to the 1.0.0 milestone Mar 14, 2019
@RomainLanz
Copy link
Member

RomainLanz commented Mar 17, 2019

Hey @borie88! 👋

I'm closing this for the moment since we are doing big refactoring for the next release (including TS rewrite).

You can still safely use your driver by extending the manager like you are doing now.
Feel free to re-open a PR with the needed change when the next release will be out. 🤗

@RomainLanz RomainLanz closed this Mar 17, 2019
@borie88
Copy link
Author

borie88 commented Mar 18, 2019

Ok, does that mean I'll need to redo the extension in TS? Also, I highly recommend we figure out a good way to implement testing for this as it needs credentials and a bucket to work correctly. I would not recommend docker only if there is no generic solution

@adlanarifzr
Copy link

Hi @borie88 . May I know if this PR will be continued?

@borie88
Copy link
Author

borie88 commented Feb 29, 2020

Hey @adlanarifzr . Yes, I actually have a typescript version ready in my fork. Will submit a pull request in the coming days once the automated testing gets figured out

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants