Matter Thermostat extend Air Quality Sensor #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lualibs imported to thermostat Capabilities added to test profile; greater unit conversion inclusion do_configure logic updated to include aqs and ap + thermostat profiles do_configure logic updated to include aqs and ap + thermostat profiles
Allows for profiles to be created that use any combination of AQS, thermostat, and fan device types. Also adds a new profile that includes much of this extended functionality.
hcarter-775
requested review from
ctowns,
z-michel,
jacobvoegele and
nickolas-deboom
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against cdf373c |
|
Channel deleted. |
ctowns
reviewed
Jul 1, 2024
ctowns
reviewed
Jul 1, 2024
ctowns
reviewed
Jul 1, 2024
ctowns
reviewed
Jul 1, 2024
|
Completed Testing: |
ctowns
reviewed
Jul 8, 2024
ctowns
reviewed
Jul 8, 2024
ctowns
reviewed
Jul 8, 2024
hcarter-775
force-pushed
the
matter-thermostat-extend-aqs
branch
from
69c722e
to
520ee59
Compare
ctowns
reviewed
Jul 8, 2024
ctowns
reviewed
Jul 8, 2024
ctowns
reviewed
Jul 8, 2024
|
Tested with 52 and 53 lua libs and confirmed that AiDot Air Purifier will onboard and correctly switch to |
|
This is looking good, great work @hcarter-775 !! One last thing would be to add some unit tests. This change is mostly to onboarding, so I think this would be a good unit test:
|
ctowns
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
This looks good to me - great work @hcarter-775 !
An overview of the testing done on this PR can be seen here: https://smartthings.atlassian.net/wiki/spaces/~62de3b63b6b0b70770d7905d/pages/3317399870/Matter+Thermostat+AQS+Support+Testing
Multiple Air Purifer devices were tested and confirmed to onboard to the correct profile and work correctly on both current (v53) and old (v52) lua libs. Additional regression testing was done with the VDA to ensure other devices in the driver continue to work correctly with these changes.
edit: also, don't forget to squash your commits!
ctowns
pushed a commit
that referenced
this pull request
Jul 12, 2024
Allows for profiles to be created that use any combination of AQS, thermostat, and fan device types. Also adds a new profile that includes much of this extended functionality. * new cluster definitions imported to thermostat * greater unit conversion inclusion * do_configure logic updated to include aqs and ap + thermostat profiles * added air purifier test cases for unit conversion and device configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for profiles to be created that use any combination of AQS, thermostat, and fan device types. Also adds a new profile that includes much of this extended functionality.