Cherry Pick: Matter Thermostat extend Air Quality Sensor #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for profiles to be created that use any combination of AQS, thermostat, and fan device types. Also adds a new profile that includes much of this extended functionality. * new cluster definitions imported to thermostat * greater unit conversion inclusion * do_configure logic updated to include aqs and ap + thermostat profiles * added air purifier test cases for unit conversion and device configuration
ctowns
requested review from
z-michel,
lelandblue,
hcarter-775 and
nickolas-deboom
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
Test Results 60 files 377 suites 0s ⏱️ Results for commit 62853a0. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 62853a0 |
ctowns
changed the title
hcarter-775
approved these changes
Jul 12, 2024
nickolas-deboom
approved these changes
Jul 12, 2024
z-michel
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cherry-pick to beta of #1479 . This will only be expedited to beta, not production. It should go to production next week with the regular driver deploy.
Testing of this change has been documented here: https://smartthings.atlassian.net/wiki/spaces/~62de3b63b6b0b70770d7905d/pages/3317399870/Matter+Thermostat+AQS+Support+Testing. This includes testing of two Air Purifier Devices on 52 lua libs (without Matter 1.2 clusters in lua libs) and 53 lua libs (with Matter 1.2 cluster in lua libs), as well as regression testing with the VDA with a thermostat and air purifier device.
Allows for profiles to be created that use any combination of AQS, thermostat, and fan device types. Also adds a new profile that includes much of this extended functionality.