Devws for most target limited co 144 #35585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tpmanley Thank you for your suggestions, (SmartThingsCommunity#13835 (comment)), I followed your suggestions to update the code. Thank you for reviewing the code again.
@greens Thank you review. Fixed bugs and code style issues.
1、In the last version，After the 2 or 3 button are pressed, LEVEL_CONTROL_CLUSTER and ADUROSMART_SPECIFIC_CLUSTER two rawdata are reported at the same time, and LEVEL_CONTROL_CLUSTER will be reported multiple times, 2、Now， so the analysis of the button data of LEVEL_CONTROL_CLUSTER on the 2 or 3 button is removed, and only parsed the data of ADUROSMART_SPECIFIC_CLUSTER on the 2 or 3 button, so that other engineer can get the single push event result of triggered by the once press button 2 or 3.
|
Will this also fix the battery reporting? It currently shows 0% in the app since the device never reports it. |
|
@prjct92eh2 |
cgmckeever
reviewed
Jul 3, 2020
| } else if (descMap.command == "00") { | ||
| buttonNumber = 4 | ||
| } | ||
| } else if (descMap.clusterInt == ADUROSMART_SPECIFIC_CLUSTER) { |
There was a problem hiding this comment.
This could possibly register dual events.
Solve the problem of duplication of 1 and 4 button events in the dimming remote control
|
@greens |
|
@adurosmart report that this handler is still flakey ... Also, you wont get an approval on the code till conflicts are resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1, In the last version，After the button 2 or 3 is pressed, LEVEL_CONTROL_CLUSTER and ADUROSMART_SPECIFIC_CLUSTER two raw data are reported at the same time, and LEVEL_CONTROL_CLUSTER will be reported multiple times,
2,Now, the analysis of the button data of LEVEL_CONTROL_CLUSTER on the button 2 or 3 is removed, and only parsed the data of ADUROSMART_SPECIFIC_CLUSTER on the button 2 or 3 , so that other engineer can get the single push event result of triggered by the once press button 2 or 3.
Thank you for review.