Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ICP-5930] Fix for Ecolink Door/Window Sensor battery report #3603

Merged
merged 2 commits into from
Oct 29, 2018
Merged

[ICP-5930] Fix for Ecolink Door/Window Sensor battery report #3603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
159ce37
Fix for Ecolink Door/Window Sensor correct battery report
PKacprowiczS Oct 23, 2018
7537ca2
Better looking binding
PKacprowiczS Oct 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions ...etypes/smartthings/smartsense-open-closed-sensor.src/smartsense-open-closed-sensor.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,20 @@ def configure() {
sendEvent(name: "checkInterval", value: 2 * 60 * 60 + 1 * 60, displayed: false, data: [protocol: "zigbee", hubHardwareId: device.hub.hardwareID, offlinePingable: "1"])

log.debug "Configuring Reporting, IAS CIE, and Bindings."

def cmds = refresh() + zigbee.iasZoneConfig(30, 60 * 5) + zigbee.batteryConfig() + zigbee.temperatureConfig(30, 60 * 30)
if(getDataValue("manufacturer") == "Ecolink") {
cmds += configureEcolink()
}
// temperature minReportTime 30 seconds, maxReportTime 5 min. Reporting interval if no activity
// battery minReport 30 seconds, maxReportTime 6 hrs by default
return refresh() + zigbee.iasZoneConfig(30, 60 * 5) + zigbee.batteryConfig() + zigbee.temperatureConfig(30, 60 * 30) // send refresh cmds as part of config
return cmds
}

private configureEcolink() {
sendEvent(name: "checkInterval", value: 60 * 60, displayed: false, data: [protocol: "zigbee", hubHardwareId: device.hub.hardwareID])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the shorter checkInterval?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due Ecolink's configuration device has 30 min check interval. Anyway, this is changed pretty quick, as soon as response about successful ZoneStatus reporting configuration comes in.


def enrollCmds = zigbee.writeAttribute(0x0020, 0x0000, 0x23, 0x00001C20) + zigbee.command(0x0020, 0x03, "0200") +
zigbee.writeAttribute(0x0020, 0x0003, 0x21, 0x0028) + zigbee.command(0x0020, 0x02, "B1040000")

return zigbee.addBinding(0x0020) + refresh() + enrollCmds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll be refreshing twice. Is that intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it puts more stress on the network, but according to my previous adventures with Ecolink devices (especially Zigbee Firefighter, which would likely report 0 temperature when polled too early after pairing), I wanted to read those attributes once more before Poll Cluster configuration. Just in case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to make sure it was on purpose. Thanks.

}