Fix lux reporting and other attributes #4500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`iconcode` is provided as number, the switch case statement assumes it's a string and always defaults to 10000, fix switch case statements `percentPrecip` and `forecastIcon` attributes are a string, convert numbers to string while reporting
juano2310
approved these changes
Jun 13, 2019
|
@bflorian actually had a similar change that hasn't been merged yet #4100. I'd prefer to go with that PR since it has a ticket. @rboy1 @juano2310 could you give that a review and/or test and then we can merge it? |
|
@rboy1 I merged that other PR into master with just the lux fix. Can you rebase your change on latest |
|
Done, made a new pull request, closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iconcodeis provided as number, the switch case statement assumes it's a string and always defaults to 10000, fix switch case statementspercentPrecipandforecastIconattributes are a string, convert numbers to string while reporting@juano2310 @bflorian