163 review linting implementation and resolve errors

[samwarwick]

This PR addresses items 1-4 of the AC in #163. Resolving all linting errors is not a trivial task and should be addressed separately. I feel there is value in merging this PR now so that we can establish a baseline for progression.

ESLint has been added to package.json and can be run with npm run lint. Note that warnings are currently disabled.

The original TSlint rules (tslint.json) were converted to ESLint automatically using tslint-to-eslint-config. tslint.json has been left in the repo for now for comparison purposes but can eventually be removed.

In an attempt to get the baseline reporting as close to TSLint as possible these additional rules were disabled:

"@typescript-eslint/naming-convention": "off",
"@typescript-eslint/indent": "off",
"indent": "off",
"no-underscore-dangle": "off",
"@typescript-eslint/ban-ts-comment": "off",
"@typescript-eslint/ban-types": "off",
"prefer-const": "off",

Despite this, there are still 692 ESLint errors, compared to 444 with TSLint. Over half of them are code-formatting issues which can easily be resolved with eslint --fix. Executing a dry-run with npx eslint . --quiet --fix-dry-run indicates there are still 153 which require manual resolution.

Two code files have been modified to get the linting passing for illustration purposes. e.g. npx eslint src/core/index.ts --quiet

Before making any further code changes to satisfy the linter, I suggest:

1. Having a broader team discussion on what baseline rules to apply. The original TSLint rules are probably out-dated. Consistency across other TokenScript repos also needs consideration.
2. Reviewing the test coverage (e.g. Token Negotiator Unit Tests Uplift #156) to have greater confidence in code changes.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[nicktaras]

This is a great way forward to use ESLint instead of TSLint, thanks Sam.

1. Agree. Let's catch up to look at this.
2. Also sounds good.

I'll set up a meeting for tomorrow.