Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smile_ElasticSearch dependancies #11

Closed
cvalcke opened this issue Apr 1, 2015 · 0 comments
Closed

Smile_ElasticSearch dependancies #11

cvalcke opened this issue Apr 1, 2015 · 0 comments

Comments

@cvalcke
Copy link

cvalcke commented Apr 1, 2015

It seems like there is a Mage_Rating dependancy in this module because of the instantiation of "rating/rating_collection" in method _getDefaultRatingId of Smile_ElasticSearch_Model_Resource_Engine_Index class.

If Mage_Rating has been disabled an error occur during the index rebuild.
afoucret added a commit that referenced this issue Jul 1, 2015
@afoucret
Merge pull request #16 from nicosomb/fix-mage-rating-dependancies
9bfed8f 
fix #11: Test if Mage_Rating module is enabled
@kayaj kayaj mentioned this issue Jul 16, 2015
Closed
nicosomb pushed a commit that referenced this issue Sep 14, 2015
fix #11: PHP compatibility
f5f1c05
afoucret pushed a commit that referenced this issue Sep 14, 2015
Merge branch 'fix-php-compat' into 'master'
53db977 
Fix #11: php compatibility
nicosomb pushed a commit that referenced this issue Sep 14, 2015
fix #11: PHP compatibility
b318544
@ali-husain ali-husain mentioned this issue Sep 18, 2015
Closed
@andy1786 andy1786 mentioned this issue Mar 7, 2016
Closed
@Fuzzzzy Fuzzzzy mentioned this issue Dec 11, 2017
Closed
@imokweb imokweb mentioned this issue Dec 18, 2017
Open
@eugeneto eugeneto mentioned this issue Mar 29, 2018
Open
@darshan-khatri-16 darshan-khatri-16 mentioned this issue Jul 17, 2018
Closed
@kinexm kinexm mentioned this issue Oct 19, 2018
Open
@eVo93 eVo93 mentioned this issue Feb 18, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cvalcke