Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for TCP segment size calculation issue. #2658

Merged

Conversation

slaff
Copy link
Contributor

@slaff slaff commented Aug 10, 2023

Original fix is here: lwip-tcpip/lwip@8e8571d

Issue spotted and documented here: #2654

PR submitted to upstream: pfalcon/esp-open-lwip#10

Fixes #2654

Original fix is here: lwip-tcpip/lwip@8e8571d

Issue spotted and documented here: SmingHub#2654

PR submitted to upstream: pfalcon/esp-open-lwip#10
@slaff slaff added this to the 5.1.0 milestone Aug 10, 2023
@what-the-diff
Copy link

what-the-diff bot commented Aug 10, 2023

PR Summary

  • Improved Computation of oversize_used Variable
    The update made to the tcp_out.c file ensures the oversize_used variable is now calculated by considering the smallest value between space, oversize, and len variables. This is handled by the LWIP_MIN function, contributing to a more robust and efficient calculation method.

@slaff slaff merged commit 9a21439 into SmingHub:develop Aug 10, 2023
36 checks passed
xeonqq pushed a commit to xeonqq/Sming that referenced this pull request Sep 11, 2023
Original fix is here: lwip-tcpip/lwip@8e8571d

Issue spotted and documented here: SmingHub#2654

PR submitted to upstream: pfalcon/esp-open-lwip#10
@slaff slaff mentioned this pull request Oct 24, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential lwip / networking issue?
2 participants