xwm: Only set _NET_WM_STATE if it has changed #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like a copy-paste error.
EWMH says a client MUST use a client message to change this, so this should be managed by the compositor and it is not necessary to read the value from X. Assuming the `X11Surface` exists for the lifetime of the X window, and the compositor only sets this via `change_net_state`. Fixes pop-os/cosmic-comp#90. This should also generally perform better since it removes a `get_property` call which has to wait on the X server, and it doesn't allocate a `HashSet`. For what difference that makes.
Drakulix
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EWMH says a client MUST use a client message to change this, so this should be managed by the compositor and it is not necessary to read the value from X. Assuming the
X11Surfaceexists for the lifetime of the X window, and the compositor only sets this viachange_net_state.Fixes pop-os/cosmic-comp#90. This should also generally perform better since it removes a
get_propertycall which has to wait on the X server, and it doesn't allocate aHashSet. For what difference that makes.This also fixes what appears to be a mistake in
update_net_window_type.