Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreXZ Support #748

Merged
merged 6 commits into from
Oct 2, 2015
Merged

CoreXZ Support #748

merged 6 commits into from
Oct 2, 2015

Conversation

jnjackins
Copy link
Contributor

I've added support for CoreXZ style 3D printers (http://forums.reprap.org/read.php?2,377858)

I''d be happy to contribute the changes upstream. Please have a look and tell me what you think of my approach.

Another approach would be to integrate the CoreXZSolution code with the HBotSolution code with a configuration option such as hbot_motion_plane, letting users choose an XY configuration for HBot or CoreXY style machines, and XZ for CoreXZ style machines. This would reduce duplicate/similar code, but also add complexity.

@wolfmanjm
Copy link
Contributor

This look fine except rather than provide a whole new config file, just provide the few lines of config and put it in the Snippets directory.

@wolfmanjm
Copy link
Contributor

Also maybe you should add options settable by M665 like the delta solution does to give an alternative for setting the reduction configuration.

@jnjackins
Copy link
Contributor Author

Re: M665 - I'm not sure there's much point. These reduction values aren't something that ever needs calibration or adjustment; they should always be round numbers that are fundamental to the design of the machine. If you feel strongly about it, though, I can add it.

@wolfmanjm
Copy link
Contributor

ok no problem, just remove the sample config, and create a snippet instead.
Thanks

@jnjackins
Copy link
Contributor Author

Already done :)

wolfmanjm added a commit that referenced this pull request Oct 2, 2015
@wolfmanjm wolfmanjm merged commit 18aa44d into Smoothieware:edge Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants