Added item data, Added handlers to fetch item data and format it, Added starting gear #72
Conversation
BrunoCDev
commented
Apr 27, 2023
•
BrunoCDev
commented
- Added item data in json format (folder data/items...)
- Added some handlers/parsers to format this data into something we can actually consume (We can call generateItem() in handlers/item.py to create any item that we have data for).
- Starting gear for each class is being generated using this and applied to the character in lobby.
- Added enums for all items for easier development.
- Modified starting gear to include gold for testing purposes.
BrunoCDev
force-pushed
the
item-selector
branch
from
af76e18
to
11e6958
Compare
|
great work! |
BrunoCDev
force-pushed
the
item-selector
branch
from
115db95
to
6752055
Compare
BrunoCDev
force-pushed
the
item-selector
branch
from
eda8885
to
3923691
Compare
dndserver/handlers/character.py
Outdated
|
|
||
|
|
||
| def create_items_per_class(char_class): | ||
| if CharacterClass.BARBARIAN == char_class: |
There was a problem hiding this comment.
Would this not be simpler to be refactored as a match-case?
dndserver/handlers/item.py
Outdated
| json_data = {} | ||
|
|
||
|
|
||
| def loadJsonData(): |
dndserver/handlers/item.py
Outdated
| for itemType in ItemType: | ||
| type = str(itemType.value) | ||
| path = os.path.join(current_dir, "..", "data", "items", type) | ||
| path = os.path.abspath(path) |
There was a problem hiding this comment.
Recasting variables is generally bad practice.
dndserver/handlers/item.py
Outdated
| type = str(itemType.value) | ||
| path = os.path.join(current_dir, "..", "data", "items", type) | ||
| path = os.path.abspath(path) | ||
| files = [file for file in os.listdir(path) if file.endswith(".json")] |
There was a problem hiding this comment.
I couldn't get it to work using glob, haven't used it before so not sure what I'm doing wrong. But if I use glob it includes the full path to the property key I'm trying to set. With the current implementation it sets it with the item name correctly (see screenshot).
Feel free to change this implementation if you can get it to work with glob...
dndserver/handlers/item.py
Outdated
|
|
||
|
|
||
| # Gets the relevant data depending on the item name and type | ||
| def getContent(name, type, rarity): |
dndserver/handlers/item.py
Outdated
| content = {} | ||
| dynamic_file_name = "" | ||
| typeValue = str(type.value) | ||
| file_name_no_rarity = name + ".json" |
There was a problem hiding this comment.
It would be more consistent to use f-strings instead of string concats.
dndserver/handlers/item.py
Outdated
| file_name_no_rarity = name + ".json" | ||
|
|
||
| if rarity == Rarity.NONE.value: | ||
| if file_name_no_rarity in json_data.get(typeValue, {}): |
There was a problem hiding this comment.
Could you explain the point of the {} fallback instead of a usual None fallback? Is there a reason we're providing an explicit fallback?
There was a problem hiding this comment.
Yeah, no need, changed it to None now
dndserver/handlers/item.py
Outdated
|
|
||
|
|
||
| # Function to be called in order to create an item | ||
| def generateItem(name, type, rarity, itemCount): |
There was a problem hiding this comment.
Function name and variable name for itemCount
dndserver/handlers/party.py
Outdated
| party = get_party_by_account_id(int(req.returnAccountId)) # todo: we're storing the first player as a transport and the next as a user object | ||
| party = get_party_by_account_id( | ||
| int(req.returnAccountId) | ||
| ) # todo: we're storing the first player as a transport and the next as a user object |
There was a problem hiding this comment.
I'm pretty sure this is no longer true and this comment can probably be removed but needs verification?
There was a problem hiding this comment.
Didn't change any of this, only change is due to formatting
… starting items for testing
BrunoCDev
force-pushed
the
item-selector
branch
from
70233c4
to
e730e82
Compare
