Add table and tab editor #25

Yasamato · 2021-04-14T12:12:21Z

flask backend

move to SQLAlchemy
switch to usage via mariaDB/postgress
reimplement table data manipulation
add table api endpoints
add tab api endpoints
add column api endpoints
handling data manipulation on column changes

~~# flutter frontend~~

flutter seems to be not the ideal choice for web projects with our requirements... abandoned in favor of react

react frontend

This is currently a breaking build and WIP

Simply because it is just way more powerful than dataset

lgtm-com · 2021-04-14T12:26:50Z

This pull request introduces 35 alerts when merging b24ec62 into b9cc91a - view on LGTM.com

new alerts:

19 for Information exposure through an exception
15 for Reflected server-side cross-site scripting
1 for Unused import

lgtm-com · 2021-04-14T13:22:19Z

This pull request introduces 35 alerts when merging 3cab556 into b9cc91a - view on LGTM.com

new alerts:

19 for Information exposure through an exception
15 for Reflected server-side cross-site scripting
1 for Unused import

lgtm-com · 2021-04-14T14:25:33Z

This pull request introduces 40 alerts when merging 55c53c9 into b9cc91a - view on LGTM.com

new alerts:

22 for Information exposure through an exception
16 for Reflected server-side cross-site scripting
2 for Unused import

lgtm-com · 2021-04-14T15:09:58Z

This pull request introduces 2 alerts and fixes 1 when merging faa07b2 into b9cc91a - view on LGTM.com

new alerts:

2 for Reflected server-side cross-site scripting

fixed alerts:

1 for Inefficient regular expression

lgtm-com · 2021-04-14T15:37:27Z

This pull request introduces 2 alerts and fixes 1 when merging fa98b82 into b9cc91a - view on LGTM.com

new alerts:

2 for Reflected server-side cross-site scripting

fixed alerts:

1 for Inefficient regular expression

lgtm-com · 2021-04-14T16:07:37Z

This pull request fixes 1 alert when merging 40d1dcb into b9cc91a - view on LGTM.com

fixed alerts:

1 for Inefficient regular expression

lgtm-com · 2021-04-14T20:00:38Z

This pull request fixes 1 alert when merging e81360c into b9cc91a - view on LGTM.com

fixed alerts:

1 for Inefficient regular expression

lgtm-com · 2021-04-14T21:27:26Z

This pull request introduces 1 alert and fixes 1 when merging 5edde27 into b9cc91a - view on LGTM.com

new alerts:

1 for Unused import

fixed alerts:

1 for Inefficient regular expression

No need to run the github action twice on active PRs

lgtm-com · 2021-04-15T15:29:51Z

This pull request fixes 1 alert when merging f6b11b1 into b9cc91a - view on LGTM.com

fixed alerts:

1 for Inefficient regular expression

lgtm-com · 2021-04-15T16:52:07Z

This pull request fixes 1 alert when merging bfa9561 into b9cc91a - view on LGTM.com

fixed alerts:

1 for Inefficient regular expression

Yasamato · 2021-04-16T22:21:45Z

src/components/TableView.tsx

+    }
+
+    toggleColumn(cols: TableColumnData[]) {
+        this.setState({cols: cols});


Codacy has a fix for the issue: Expected property shorthand.

Suggested change

this.setState({cols: cols});

this.setState({cols});

Yasamato · 2021-04-16T22:21:46Z

src/index.tsx

+import ReactDOM from "react-dom";
+import './index.css';
+import App from './App';
+import reportWebVitals from './reportWebVitals';


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

import reportWebVitals from './reportWebVitals';

import reportWebVitals from "./reportWebVitals";

Yasamato · 2021-04-16T22:21:47Z

src/App.tsx

+        fetch(debugUrl + "/api/tables")
+            .then(r => r.json())
+            .then(tables => {
+                this.setState({tables: tables});


Codacy has a fix for the issue: Expected property shorthand.

Suggested change

this.setState({tables: tables});

this.setState({tables});

Yasamato · 2021-04-16T22:21:48Z

src/index.tsx

@@ -0,0 +1,18 @@
+import React from 'react';
+import ReactDOM from "react-dom";
+import './index.css';


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

import './index.css';

import "./index.css";

Yasamato · 2021-04-16T22:21:49Z

src/App.tsx

@@ -0,0 +1,68 @@
+import React from "react";
+import './App.css';
+import IndexNavbar from './components/IndexNavbar';


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

import IndexNavbar from './components/IndexNavbar';

import IndexNavbar from "./components/IndexNavbar";

Yasamato · 2021-04-16T22:21:50Z

src/App.tsx

+        return (
+            <div className="App" style={{
+                backgroundColor: "#1f1f1f",
+                minHeight: '100vh',


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

minHeight: '100vh',

minHeight: "100vh",

Yasamato · 2021-04-16T22:21:52Z

src/App.tsx

@@ -0,0 +1,68 @@
+import React from "react";
+import './App.css';


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

import './App.css';

import "./App.css";

Yasamato · 2021-04-16T22:25:24Z

Replaced by #33

Yasamato added 4 commits April 13, 2021 11:58

Prepare backend api for tab edits

f4fec4b

This is currently a breaking build and WIP

Reorder Dockerfile for better build cache

83d6a66

Switched to SQLAlchemy

8ecc665

Simply because it is just way more powerful than dataset

Correct api endpoints

b24ec62

Yasamato added the enhancement New feature or request label Apr 14, 2021

This was referenced Apr 14, 2021

[FEAT] add PWA functionality #26

Closed

[FEAT] advanced search functionality #27

Closed

Yasamato added 3 commits April 14, 2021 14:58

Update static/js/utils.js

8c8f3b0

Update static/js/utils.js

7c9c8c5

Cleanup misc

3cab556

Return IDs instead of whole objects

55c53c9

Yasamato added 3 commits April 14, 2021 16:36

Log errors only to console

4882cc2

Adjust .gitignore

a7c7598

Flutter init

faa07b2

Cleanup ignore files and Dockerfile

fa98b82

Fix docker build

40d1dcb

Yasamato added 2 commits April 14, 2021 21:27

Misc. code cleanup

77c4e2d

Adjust github issue templates

e81360c

Add allow CORS to /api fetch only routes

5edde27

Yasamato added 3 commits April 15, 2021 00:05

Adjust Dart version

4ef8176

Only run github action on push

173a390

No need to run the github action twice on active PRs

Update queries.py

1a7e4b7

Add inital fetch layouts

f6b11b1

Sticky header

bfa9561

Yasamato added 15 commits April 16, 2021 01:09

Adjust API to respond recursivly

bde812d

Drop flutter, replace with React

a6a2ed5

Update src/App.tsx

2aee2e0

Update src/App.tsx

9e9fa6a

Update src/App.tsx

3c7c8cf

Update src/index.tsx

ce25c6f

Update src/index.tsx

4388f86

Correctly bind callbacks

408e4d2

Update src/App.tsx

409c4e7

Update src/App.tsx

023f94b

Update src/App.tsx

8f637ca

Update src/index.tsx

2bf4f57

Update src/components/TableColumnTogglesView.tsx

2d37bd7

Add dev instructions

7e63f80

Make file links in README.md

a1270ca

Yasamato commented Apr 16, 2021

View reviewed changes

Yasamato closed this Apr 16, 2021

Yasamato deleted the web-flutter branch April 16, 2021 22:22

Yasamato mentioned this pull request Apr 16, 2021

New React Frontend #33

Closed

21 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add table and tab editor #25

Add table and tab editor #25

Yasamato commented Apr 14, 2021 •

edited by Snaacky

lgtm-com bot commented Apr 14, 2021

lgtm-com bot commented Apr 14, 2021

lgtm-com bot commented Apr 14, 2021

lgtm-com bot commented Apr 14, 2021

lgtm-com bot commented Apr 14, 2021

lgtm-com bot commented Apr 14, 2021

lgtm-com bot commented Apr 14, 2021

lgtm-com bot commented Apr 14, 2021

lgtm-com bot commented Apr 15, 2021

lgtm-com bot commented Apr 15, 2021

Yasamato Apr 16, 2021

Yasamato Apr 16, 2021

Yasamato Apr 16, 2021

Yasamato Apr 16, 2021

Yasamato Apr 16, 2021

Yasamato Apr 16, 2021

Yasamato Apr 16, 2021

Yasamato commented Apr 16, 2021

	import reportWebVitals from './reportWebVitals';
	import reportWebVitals from "./reportWebVitals";

	import IndexNavbar from './components/IndexNavbar';
	import IndexNavbar from "./components/IndexNavbar";

		@@ -0,0 +1,68 @@
		import React from "react";
		import './App.css';

Add table and tab editor #25

Add table and tab editor #25

Conversation

Yasamato commented Apr 14, 2021 • edited by Snaacky

flask backend

react frontend

lgtm-com bot commented Apr 14, 2021

lgtm-com bot commented Apr 14, 2021

lgtm-com bot commented Apr 14, 2021

lgtm-com bot commented Apr 14, 2021

lgtm-com bot commented Apr 14, 2021

lgtm-com bot commented Apr 14, 2021

lgtm-com bot commented Apr 14, 2021

lgtm-com bot commented Apr 14, 2021

lgtm-com bot commented Apr 15, 2021

lgtm-com bot commented Apr 15, 2021

Yasamato Apr 16, 2021

Choose a reason for hiding this comment

Yasamato Apr 16, 2021

Choose a reason for hiding this comment

Yasamato Apr 16, 2021

Choose a reason for hiding this comment

Yasamato Apr 16, 2021

Choose a reason for hiding this comment

Yasamato Apr 16, 2021

Choose a reason for hiding this comment

Yasamato Apr 16, 2021

Choose a reason for hiding this comment

Yasamato Apr 16, 2021

Choose a reason for hiding this comment

Yasamato commented Apr 16, 2021

Yasamato commented Apr 14, 2021 •

edited by Snaacky