-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration of per-rule cluster settings #7
Comments
This makes me think that the cluster configuration YAML file shouldn't be deprecated. I've seen a number of cases where it's still very nice to have, and I think that using profiles supplements the use of the cluster config rather than replaces it. |
The problem I had with cluster configs though was if I wanted to define a cluster argument that wasn't relevant for any other jobs it was kind of impossible. i.e. if one just was for a GPU node and the others weren't. I have edited the original comment to reflect my idea. |
@mbhall88 I wonder if you could just have an "extra" entry in the cluster-config, and include |
Who knows, maybe cluster config will be "un-deprecated" in the future, but I would rather plan ahead for now. It won't be too hard to move the codebase to your suggested method if it does. |
Fair enough. Although I've been griping a bit, I do really appreciate you taking the time to develop this profile and I think it's quite nice! |
Issue
Profiles are a better general solution for cluster configuration. However, I still feel there is a need to allow for configuring special cluster settings for specific rules.
For example, on my cluster, if I want to use GPUs for a job I need to add a collection of parameters to the
bsub
call that are not relevant to normal jobs. It would be great if there was a way of specifying this.Given that the cluster configuration is now deprecated it seems like a better way of doing per-rule configuration is to have a profile-specific way as each cluster will likely have different ways of configuring the "same" thing - e.g. GPU usage.
Proposal
Allow for an LSF-specific config file that effectively has much the same functionality as the deprecated cluster configuration YAML file. To ensure that it is obvious that this file is LSF-specific it will be required to be named
lsf.yaml
. Then, within the job submission process of this profile, we will look for the presence of this file. If there are specific settings for the current rule being submitted, then those settings will be applied.To make this mirror LSF as much as possible, I will endeavour to make the configuration mirror the LSFbsub
options as closely as possible, and of course, produce thorough documentation on usage.EDIT: I think the best way to allow for the full suite of
bsub
commands is by just required the user to provide strings for the commands, otherwise I would end up implementing an entire API forbsub
(which I am not keen on). So it would look something likeWhich allows either a list or a single string. I prefer the list as it is "neater" but I will support both.
@johanneskoester do you have any problems with this or any points you would like to raise/discuss?
The text was updated successfully, but these errors were encountered: