Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required RBAC resources to the helm chart #30

Merged
merged 9 commits into from
Apr 10, 2024
Merged

Add required RBAC resources to the helm chart #30

merged 9 commits into from
Apr 10, 2024

Conversation

s-vitaliy
Copy link
Contributor

@s-vitaliy s-vitaliy commented Apr 10, 2024 •
edited
Loading

Scope

Implemented:

  • Added RBAC resources required for Arcane.Operator to work

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@github-actions GitHub Actions
Copy link

Coverage after merging add-cluster-role-bindings into main will be

54.23%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   ArcaneEnvironment.cs0%100%0%0%10, 5, 8–9
src/Extensions
   JsonElementExtensions.cs0%100%0%0%20
   V1JobExtensions.cs85.58%75%90.91%90.16%40, 40, 45, 61–62, 62, 62, 62, 62–65, 83, 83
src/Models/StreamClass
   V1Beta1StreamClassSpec.cs20%100%20%20%11, 17, 23, 29
src/Models/StreamClass/Base
   IStreamClass.cs0%100%0%0%44–49
src/Models/StreamDefinitions/Base
   IStreamDefinition.cs90%83.33%100%100%28
src/Models/StreamStatuses/StreamStatus/V1Beta1
   V1Beta1StreamStatus.cs100%100%100%100%
src/Services
   StreamInteractionService.cs0%100%0%0%16–19, 23–27, 31–35, 39–45
src/Services/Maintenance
   HostedStreamingJobMaintenanceService.cs0%0%0%0%16–24, 27–29, 29, 29–36, 39–42
   StreamingJobMaintenanceService.cs89.84%82.14%100%91.40%104–107, 122, 131–134, 136, 62, 67, 98
src/Services/Operator
   HostedStreamOperatorService.cs82.14%100%66.67%82.61%39–42
   StreamClassOperatorService.cs77.57%50%80%80.46%100, 107–110, 125–128, 83, 83, 86, 88, 93–95, 95, 95–99
   StreamOperatorService.cs93.47%87.04%100%95.65%107–113, 118, 126, 140, 140, 146, 168
   StreamOperatorServiceWorker.cs77.78%50%75%80%47–51, 56, 64
   StreamOperatorServiceWorkerFactory.cs100%100%100%100%
src/Services/Repositories
   StreamDefinitionRepository.cs0%0%0%0%100–111, 22–29, 32–34, 34, 34–49, 53–62, 62, 62–76, 79–81, 81, 81–93, 96–98, 98, 98–99
   StreamingJobTemplateRepository.cs0%0%0%0%20–27, 31–33, 33, 33, 33, 33, 33, 33, 33, 33–36, 39–47
src/Services/Streams
   StreamingJobOperatorService.cs0%0%0%0%100–107, 110–113, 113, 113–115, 118–121, 121, 121–123, 126–129, 129, 129–131, 134–137, 140–146, 150–152, 152, 152, 152, 152–155, 155, 155, 155, 155–156, 158–161, 163–169, 173, 173, 173, 173, 173–179, 182–188, 191–200, 31–43, 46, 49–56, 59–60, 60, 60–63, 63, 63–70, 70, 70–90, 90, 90, 90, 90–93, 93, 93–99

@github-actions GitHub Actions
Copy link

Coverage after merging add-cluster-role-bindings into main will be

54.23%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   ArcaneEnvironment.cs0%100%0%0%10, 5, 8–9
src/Extensions
   JsonElementExtensions.cs0%100%0%0%20
   V1JobExtensions.cs85.58%75%90.91%90.16%40, 40, 45, 61–62, 62, 62, 62, 62–65, 83, 83
src/Models/StreamClass
   V1Beta1StreamClassSpec.cs20%100%20%20%11, 17, 23, 29
src/Models/StreamClass/Base
   IStreamClass.cs0%100%0%0%44–49
src/Models/StreamDefinitions/Base
   IStreamDefinition.cs90%83.33%100%100%28
src/Models/StreamStatuses/StreamStatus/V1Beta1
   V1Beta1StreamStatus.cs100%100%100%100%
src/Services
   StreamInteractionService.cs0%100%0%0%16–19, 23–27, 31–35, 39–45
src/Services/Maintenance
   HostedStreamingJobMaintenanceService.cs0%0%0%0%16–24, 27–29, 29, 29–36, 39–42
   StreamingJobMaintenanceService.cs89.84%82.14%100%91.40%104–107, 122, 131–134, 136, 62, 67, 98
src/Services/Operator
   HostedStreamOperatorService.cs82.14%100%66.67%82.61%39–42
   StreamClassOperatorService.cs77.57%50%80%80.46%100, 107–110, 125–128, 83, 83, 86, 88, 93–95, 95, 95–99
   StreamOperatorService.cs93.47%87.04%100%95.65%107–113, 118, 126, 140, 140, 146, 168
   StreamOperatorServiceWorker.cs77.78%50%75%80%47–51, 56, 64
   StreamOperatorServiceWorkerFactory.cs100%100%100%100%
src/Services/Repositories
   StreamDefinitionRepository.cs0%0%0%0%100–111, 22–29, 32–34, 34, 34–49, 53–55, 55, 55–76, 79–81, 81, 81–93, 96–98, 98, 98–99
   StreamingJobTemplateRepository.cs0%0%0%0%20–27, 31–33, 33, 33, 33, 33, 33, 33, 33, 33–36, 39–47
src/Services/Streams
   StreamingJobOperatorService.cs0%0%0%0%100–107, 110–113, 113, 113–115, 118–121, 121, 121–123, 126–129, 129, 129–131, 134–137, 140–146, 150–152, 152, 152, 152, 152–155, 155, 155, 155, 155–156, 158–161, 163–169, 173, 173, 173, 173, 173–179, 182–188, 191–200, 31–43, 46, 49–56, 59–60, 60, 60–63, 63, 63–70, 70, 70–90, 90, 90, 90, 90–93, 93, 93–99

@github-actions GitHub Actions
Copy link

Coverage after merging add-cluster-role-bindings into main will be

54.23%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   ArcaneEnvironment.cs0%100%0%0%10, 5, 8–9
src/Extensions
   JsonElementExtensions.cs0%100%0%0%20
   V1JobExtensions.cs85.58%75%90.91%90.16%40, 40, 45, 61–62, 62, 62, 62, 62–65, 83, 83
src/Models/StreamClass
   V1Beta1StreamClassSpec.cs20%100%20%20%11, 17, 23, 29
src/Models/StreamClass/Base
   IStreamClass.cs0%100%0%0%44–49
src/Models/StreamDefinitions/Base
   IStreamDefinition.cs90%83.33%100%100%28
src/Models/StreamStatuses/StreamStatus/V1Beta1
   V1Beta1StreamStatus.cs100%100%100%100%
src/Services
   StreamInteractionService.cs0%100%0%0%16–19, 23–27, 31–35, 39–45
src/Services/Maintenance
   HostedStreamingJobMaintenanceService.cs0%0%0%0%16–24, 27–29, 29, 29–36, 39–42
   StreamingJobMaintenanceService.cs89.84%82.14%100%91.40%104–107, 122, 131–134, 136, 62, 67, 98
src/Services/Operator
   HostedStreamOperatorService.cs82.14%100%66.67%82.61%39–42
   StreamClassOperatorService.cs77.57%50%80%80.46%100, 107–110, 125–128, 83, 83, 86, 88, 93–95, 95, 95–99
   StreamOperatorService.cs93.47%87.04%100%95.65%107–113, 118, 126, 140, 140, 146, 168
   StreamOperatorServiceWorker.cs77.78%50%75%80%47–51, 56, 64
   StreamOperatorServiceWorkerFactory.cs100%100%100%100%
src/Services/Repositories
   StreamDefinitionRepository.cs0%0%0%0%100–111, 22–29, 32–34, 34, 34–49, 53–55, 55, 55–76, 79–81, 81, 81–93, 96–98, 98, 98–99
   StreamingJobTemplateRepository.cs0%0%0%0%20–27, 31–33, 33, 33, 33, 33, 33, 33, 33, 33–36, 39–47
src/Services/Streams
   StreamingJobOperatorService.cs0%0%0%0%100–107, 110–113, 113, 113–115, 118–121, 121, 121–123, 126–129, 129, 129–131, 134–137, 140–146, 150–152, 152, 152, 152, 152–155, 155, 155, 155, 155–156, 158–161, 163–169, 173, 173, 173, 173, 173–179, 182–188, 191–200, 31–43, 46, 49–56, 59–60, 60, 60–63, 63, 63–70, 70, 70–90, 90, 90, 90, 90–93, 93, 93–99

@github-actions GitHub Actions
Copy link

Coverage after merging add-cluster-role-bindings into main will be

54.23%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   ArcaneEnvironment.cs0%100%0%0%10, 5, 8–9
src/Extensions
   JsonElementExtensions.cs0%100%0%0%20
   V1JobExtensions.cs85.58%75%90.91%90.16%40, 40, 45, 61–62, 62, 62, 62, 62–65, 83, 83
src/Models/StreamClass
   V1Beta1StreamClassSpec.cs20%100%20%20%11, 17, 23, 29
src/Models/StreamClass/Base
   IStreamClass.cs0%100%0%0%44–49
src/Models/StreamDefinitions/Base
   IStreamDefinition.cs90%83.33%100%100%28
src/Models/StreamStatuses/StreamStatus/V1Beta1
   V1Beta1StreamStatus.cs100%100%100%100%
src/Services
   StreamInteractionService.cs0%100%0%0%16–19, 23–27, 31–35, 39–45
src/Services/Maintenance
   HostedStreamingJobMaintenanceService.cs0%0%0%0%16–24, 27–29, 29, 29–36, 39–42
   StreamingJobMaintenanceService.cs89.84%82.14%100%91.40%104–107, 122, 131–134, 136, 62, 67, 98
src/Services/Operator
   HostedStreamOperatorService.cs82.14%100%66.67%82.61%39–42
   StreamClassOperatorService.cs77.57%50%80%80.46%100, 107–110, 125–128, 83, 83, 86, 88, 93–95, 95, 95–99
   StreamOperatorService.cs93.47%87.04%100%95.65%107–113, 118, 126, 140, 140, 146, 168
   StreamOperatorServiceWorker.cs77.78%50%75%80%47–51, 56, 64
   StreamOperatorServiceWorkerFactory.cs100%100%100%100%
src/Services/Repositories
   StreamDefinitionRepository.cs0%0%0%0%100–111, 22–29, 32–34, 34, 34–49, 53–55, 55, 55–76, 79–81, 81, 81–93, 96–98, 98, 98–99
   StreamingJobTemplateRepository.cs0%0%0%0%20–27, 31–33, 33, 33, 33, 33, 33, 33, 33, 33–36, 39–47
src/Services/Streams
   StreamingJobOperatorService.cs0%0%0%0%100–107, 110–113, 113, 113–115, 118–121, 121, 121–123, 126–129, 129, 129–131, 134–137, 140–146, 150–152, 152, 152, 152, 152–155, 155, 155, 155, 155–156, 158–161, 163–169, 173, 173, 173, 173, 173–179, 182–188, 191–200, 31–43, 46, 49–56, 59–60, 60, 60–63, 63, 63–70, 70, 70–90, 90, 90, 90, 90–93, 93, 93–99

@s-vitaliy s-vitaliy changed the title Add cluster role bindings Add required RBAC resources to the helm chart Apr 10, 2024
@github-actions GitHub Actions
Copy link

Coverage after merging add-cluster-role-bindings into main will be

54.23%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   ArcaneEnvironment.cs0%100%0%0%10, 5, 8–9
src/Extensions
   JsonElementExtensions.cs0%100%0%0%20
   V1JobExtensions.cs85.58%75%90.91%90.16%40, 40, 45, 61–62, 62, 62, 62, 62–65, 83, 83
src/Models/StreamClass
   V1Beta1StreamClassSpec.cs20%100%20%20%11, 17, 23, 29
src/Models/StreamClass/Base
   IStreamClass.cs0%100%0%0%44–49
src/Models/StreamDefinitions/Base
   IStreamDefinition.cs90%83.33%100%100%28
src/Models/StreamStatuses/StreamStatus/V1Beta1
   V1Beta1StreamStatus.cs100%100%100%100%
src/Services
   StreamInteractionService.cs0%100%0%0%16–19, 23–27, 31–35, 39–45
src/Services/Maintenance
   HostedStreamingJobMaintenanceService.cs0%0%0%0%16–24, 27–29, 29, 29–36, 39–42
   StreamingJobMaintenanceService.cs89.84%82.14%100%91.40%104–107, 122, 131–134, 136, 62, 67, 98
src/Services/Operator
   HostedStreamOperatorService.cs82.14%100%66.67%82.61%39–42
   StreamClassOperatorService.cs77.57%50%80%80.46%100, 107–110, 125–128, 83, 83, 86, 88, 93–95, 95, 95–99
   StreamOperatorService.cs93.47%87.04%100%95.65%107–113, 118, 126, 140, 140, 146, 168
   StreamOperatorServiceWorker.cs77.78%50%75%80%47–51, 56, 64
   StreamOperatorServiceWorkerFactory.cs100%100%100%100%
src/Services/Repositories
   StreamDefinitionRepository.cs0%0%0%0%100–111, 22–29, 32–34, 34, 34–49, 53–55, 55, 55–76, 79–81, 81, 81–93, 96–98, 98, 98–99
   StreamingJobTemplateRepository.cs0%0%0%0%20–27, 31–33, 33, 33, 33, 33, 33, 33, 33, 33–36, 39–47
src/Services/Streams
   StreamingJobOperatorService.cs0%0%0%0%100–107, 110–113, 113, 113–115, 118–121, 121, 121–123, 126–129, 129, 129–131, 134–137, 140–146, 150–152, 152, 152, 152, 152–155, 155, 155, 155, 155–156, 158–161, 163–169, 173, 173, 173, 173, 173–179, 182–188, 191–200, 31–43, 46, 49–56, 59–60, 60, 60–63, 63, 63–70, 70, 70–90, 90, 90, 90, 90–93, 93, 93–99

@s-vitaliy s-vitaliy marked this pull request as ready for review April 10, 2024 12:35
@s-vitaliy s-vitaliy requested a review from a team as a code owner April 10, 2024 12:35
@github-actions GitHub Actions
Copy link

Coverage after merging add-cluster-role-bindings into main will be

54.23%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   ArcaneEnvironment.cs0%100%0%0%10, 5, 8–9
src/Extensions
   JsonElementExtensions.cs0%100%0%0%20
   V1JobExtensions.cs85.58%75%90.91%90.16%40, 40, 45, 61–62, 62, 62, 62, 62–65, 83, 83
src/Models/StreamClass
   V1Beta1StreamClassSpec.cs20%100%20%20%11, 17, 23, 29
src/Models/StreamClass/Base
   IStreamClass.cs0%100%0%0%44–49
src/Models/StreamDefinitions/Base
   IStreamDefinition.cs90%83.33%100%100%28
src/Models/StreamStatuses/StreamStatus/V1Beta1
   V1Beta1StreamStatus.cs100%100%100%100%
src/Services
   StreamInteractionService.cs0%100%0%0%16–19, 23–27, 31–35, 39–45
src/Services/Maintenance
   HostedStreamingJobMaintenanceService.cs0%0%0%0%16–24, 27–29, 29, 29–36, 39–42
   StreamingJobMaintenanceService.cs89.84%82.14%100%91.40%104–107, 122, 131–134, 136, 62, 67, 98
src/Services/Operator
   HostedStreamOperatorService.cs82.14%100%66.67%82.61%39–42
   StreamClassOperatorService.cs77.57%50%80%80.46%100, 107–110, 125–128, 83, 83, 86, 88, 93–95, 95, 95–99
   StreamOperatorService.cs93.47%87.04%100%95.65%107–113, 118, 126, 140, 140, 146, 168
   StreamOperatorServiceWorker.cs77.78%50%75%80%47–51, 56, 64
   StreamOperatorServiceWorkerFactory.cs100%100%100%100%
src/Services/Repositories
   StreamDefinitionRepository.cs0%0%0%0%100–111, 22–29, 32–34, 34, 34–49, 53–55, 55, 55–76, 79–81, 81, 81–93, 96–98, 98, 98–99
   StreamingJobTemplateRepository.cs0%0%0%0%20–27, 31–33, 33, 33, 33, 33, 33, 33, 33, 33–36, 39–47
src/Services/Streams
   StreamingJobOperatorService.cs0%0%0%0%100–107, 110–113, 113, 113–115, 118–121, 121, 121–123, 126–129, 129, 129–131, 134–137, 140–146, 150–152, 152, 152, 152, 152–155, 155, 155, 155, 155–156, 158–161, 163–169, 173, 173, 173, 173, 173–179, 182–188, 191–200, 31–43, 46, 49–56, 59–60, 60, 60–63, 63, 63–70, 70, 70–90, 90, 90, 90, 90–93, 93, 93–99

@s-vitaliy s-vitaliy merged commit aea1754 into main Apr 10, 2024
2 checks passed
@s-vitaliy s-vitaliy deleted the add-cluster-role-bindings branch April 10, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adelinag08 adelinag08 adelinag08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@s-vitaliy @adelinag08