Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoHostSwap, Types.d.ts finished #1

Merged
merged 10 commits into from
Apr 20, 2024

Conversation

WolfPRAcc7
Copy link
Contributor

Couple things you should review / test:


   if (this.config.endRoomNoHostSwap) {
          this.logChatMessage(`* ${leavingPlayerName} left the game and closed the room."`);
          process.exit(0);
        }

Whether process.exit(0) is a good enough way to the close room, (I am afraid bonk will instantly kick you out since the socket is closed rather then still seeing the closed the room message)

I added an avatar shape enum however see if you want me to move this to another file or change the type to an integer
export enum eAvatarShape { // Idealy large enums like this should be moved to another file

Thirdly.
noHostSwap should also be settable through the terminal? todo

@WolfPRAcc7
Copy link
Contributor Author

Thirdly.
noHostSwap should also be settable through the terminal? todo

done

@WolfPRAcc7 WolfPRAcc7 marked this pull request as draft April 19, 2024 13:34
@WolfPRAcc7 WolfPRAcc7 marked this pull request as ready for review April 19, 2024 16:55
@SneezingCactus
Copy link
Owner

thank you!!!! I'll remove noHostSwap as setting autoAssignHost to false does basically the same thing. Room closing functionality will only be accessible through the server terminal, and instead of outright closing the server, it will keep the room open but it will also remove game host privileges to the current game host and block any attempts at joining after it's been closed.

@SneezingCactus SneezingCactus merged commit e8a3e19 into SneezingCactus:master Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants