Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create function Get-ServiceNowRequestItem #61

Merged
merged 3 commits into from
Dec 27, 2018

Conversation

replicaJunction
Copy link
Contributor

This function is copied from the Get-ServiceNowRequest function. The
only real difference is the table it queries.

I copied and pasted a simple test for this function from the
Get-ServiceNowRequest function, but I can't access the test environment
it's querying in order to validate that the test works.

I have tested this functionality against a ServiceNow instance I can access,
and I've confirmed that it's working as expected in my case.

Rick-2CA and others added 3 commits December 7, 2018 12:02
This function is copied from the Get-ServiceNowRequest function. The
only real difference is the table it queries.

I copied and pasted a simple test for this function from the
Get-ServiceNowRequest function, but I can't access the test environment
it's querying in order to validate that the test works.
@Rick-2CA
Copy link
Member

Thanks for the PR. I'll get to it as soon as I'm able.

There's no static test environment for the project. When I review for release I spin up a developer tenant via the ServiceNow website, update my local copy of ServiceNow.Pester.Defaults.json (which is listed in the .gitignore), and execute the build manually. Doing the same thing against your local instance ought to be good enough in most cases though. I intend to always run it on a clean dev tenant too.

@Rick-2CA Rick-2CA changed the base branch from master to development December 27, 2018 20:44
@Rick-2CA Rick-2CA merged commit 04173af into Snow-Shell:development Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants