Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in PSTypeName for Get-ServiceNowRequestItem #65

Merged
merged 2 commits into from
Feb 4, 2019

Conversation

replicaJunction
Copy link
Contributor

I made an error in the output object's type name when submitting PR #61. This change corrects that behavior, so that Get-ServiceNowRequestItem correctly returns an object of type ServiceNow.RequestItem instead of ServiceNow.Request. Apologies for the inconvenience.

@Rick-2CA
Copy link
Member

Rick-2CA commented Jan 3, 2019

You had it as ServiceNow.RequestItem in your last PR. I changed it on you in order to have the formatting output the same as ServiceNow.Request. What I failed to remember was how all that worked. I should have expanded ServiceNow.format.ps1xml instead. My apologies for that error and thanks for reviewing the changes to catch me.

@Rick-2CA Rick-2CA self-assigned this Jan 3, 2019
@Rick-2CA Rick-2CA added the bug label Jan 3, 2019
@Rick-2CA Rick-2CA merged commit 95eed0c into Snow-Shell:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants