Allow imports from root node_modules for scss #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrimLink
changed the title
So We don't have to change the package.json in frontools
Igloczek
suggested changes
Jul 12, 2019
|
@Igloczek I have changed it to a config via the themes.json |
|
+1 on this change. |
# Conflicts: # config/themes.json.sample # helper/scss.js
|
@Igloczek I have updated my PR with the latest release. |
|
+1 on this change here — i've needed this capability from frontools in one of our projects |
|
Hoi @Igloczek |
|
Sure, 1.9.0 will probably get those chages if everthing will be fine. |
Igloczek
approved these changes
Sep 18, 2020
Igloczek
pushed a commit
that referenced
this pull request
Sep 18, 2020
* allow imports from root node_modules for scss * IMP: allow node modules from root of Magento 2 install So We don't have to change the package.json in frontools * ADD: include path as an option via theme * FIX: typo in const * FIX: removed old changes Whoeps 😅 * IMP: re-add option to scss helper
Igloczek
pushed a commit
that referenced
this pull request
Sep 18, 2020
* allow imports from root node_modules for scss * IMP: allow node modules from root of Magento 2 install So We don't have to change the package.json in frontools * ADD: include path as an option via theme * FIX: typo in const * FIX: removed old changes Whoeps 😅 * IMP: re-add option to scss helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.