Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL Remoting #259

Merged
merged 85 commits into from Dec 4, 2017
Merged

GraphQL Remoting #259

merged 85 commits into from Dec 4, 2017

Conversation

chyyran
Copy link
Member

@chyyran chyyran commented Dec 2, 2017

This PR supersedes #254 and defines a rudimentary GraphQL remoting API.

UI code will be refactored out into it's own repository, and will be rebuilt with the GraphQL API in mind.

@codecov
Copy link

codecov bot commented Dec 3, 2017

Codecov Report

Merging #259 into master will decrease coverage by 0.55%.
The diff coverage is 75.78%.

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   73.67%   73.12%   -0.56%     
==========================================
  Files         135      134       -1     
  Lines        4050     4119      +69     
  Branches      240      253      +13     
==========================================
+ Hits         2984     3012      +28     
- Misses        993     1032      +39     
- Partials       73       75       +2

@codecov
Copy link

codecov bot commented Dec 3, 2017

Codecov Report

Merging #259 into master will increase coverage by 0.03%.
The diff coverage is 73.41%.

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   73.67%   73.71%   +0.03%     
==========================================
  Files         135      118      -17     
  Lines        4050     3880     -170     
  Branches      240      236       -4     
==========================================
- Hits         2984     2860     -124     
+ Misses        993      948      -45     
+ Partials       73       72       -1

@chyyran
Copy link
Member Author

chyyran commented Dec 4, 2017

Have to write tests for a lot of the GraphQL stuff, in particular registering queries.

@chyyran chyyran closed this Dec 4, 2017
@chyyran chyyran reopened this Dec 4, 2017
@chyyran chyyran merged commit 85d57a1 into SnowflakePowered:master Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant