Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant address #49

Merged
merged 12 commits into from
Nov 30, 2023
Merged

Remove redundant address #49

merged 12 commits into from
Nov 30, 2023

Conversation

yrong
Copy link

@yrong yrong commented Nov 28, 2023

βœ„ -----------------------------------------------------------------------------

Thank you for your Pull Request! πŸ™ Please make sure it follows the contribution guidelines outlined in
this document and fill
out the sections below. Once you're ready to submit your PR for review, please
delete this section and leave only the text under the "Description" heading.

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context,
including:

  • What does this PR do?
  • Why are these changes needed?
  • How were these changes implemented and what do they affect?

Use Github semantic
linking

to address any open issues this PR relates to or closes.

Fixes # (issue number, if applicable)

Closes # (issue number, if applicable)

Checklist

  • My PR includes a detailed description as outlined in the "Description" section above
  • My PR follows the labeling requirements of this project (at minimum one label for T
    required)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

You can remove the "Checklist" section once all have been checked. Thank you for your contribution!

βœ„ -----------------------------------------------------------------------------

@vgeddes vgeddes merged commit 27c82f9 into snowbridge Nov 30, 2023
4 of 8 checks passed
@vgeddes vgeddes deleted the remove-redundant-address branch November 30, 2023 09:17
claravanstaden pushed a commit that referenced this pull request Dec 4, 2023
* Fix compile error

* Load PricingParameters from control

* Load InboundDeliveryCost from EthereumInboundQueue

* Allow utility calls

* Fix integration tests

* Remove createAssetExecutionFee

* Fix breaking test

* fix benchmark weights

---------

Co-authored-by: Vincent Geddes <vincent.geddes@hey.com>
claravanstaden added a commit that referenced this pull request Dec 4, 2023
* updates snowbridge dependencies to git repos

* use snowbridge v0.9.0

* Rename control to system

* Remove redundant address (#49)

* Fix compile error

* Load PricingParameters from control

* Load InboundDeliveryCost from EthereumInboundQueue

* Allow utility calls

* Fix integration tests

* Remove createAssetExecutionFee

* Fix breaking test

* fix benchmark weights

---------

Co-authored-by: Vincent Geddes <vincent.geddes@hey.com>

* benchmark fixes (#55)

Co-authored-by: claravanstaden <Cats 4 life!>

* Update to EthereumSystem

* fixes related to pr comments

* fix exporter

* adds universal location check

* use ethereum network from snowbridge rococo common crate

* starts with pallet universal alias

* merge damage
Host snowbridge-dev

* use pallet instance in inbound queue origin

* cleanup

* TrustedTeleporters from SnowBridgeMessageQueue

---------

Co-authored-by: claravanstaden <Cats 4 life!>
Co-authored-by: ron <yrong1997@gmail.com>
Co-authored-by: Vincent Geddes <vincent.geddes@hey.com>
claravanstaden pushed a commit that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants