Add group label properties #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! Should be ready to be merged right after 0.9 is out. |
| def short_label(self): | ||
| """ A short description of the group """ | ||
| group_names = sorted([m.player_name for m in self.members]) | ||
| group_label = group_names[0] |
There was a problem hiding this comment.
Is this how the official controllers name groups? Perhaps they use the name of the group coordinator, rather than the first in alphabetical order, i.e. group_label = self.coordinator.player_name ... etc
There was a problem hiding this comment.
@lawrenceakka from what I can tell it's alphabetical; that gives a consistent name even if the coordinator isn't the first by name. It always seems to match for me, I've been using it for a few weeks.
|
Looks good |
|
It seems that there are some conflicts. Can you please rebase onto master? |
Conflicts: unittest/test_core.py
|
@stefankoegl rebased as requested |
lawrenceakka
added a commit
that referenced
this pull request
Oct 7, 2014
Add group label properties
Closed
dajobe
added a commit
to dajobe/sonos-utils
that referenced
this pull request
Oct 7, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the unit tests work here required a bit of thought. The group member zgs responses had to be mocked after the group XML had been parsed, so it's done in the test code.