Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace http(s) prefix in URIs to play with x-rincon-mp3radio://. Fixes #434. #443

Merged

Conversation

Projects
None yet
4 participants
@KennethNielsen
Copy link
Member

commented Nov 2, 2016

This is a fix for #434. It replaces 'https://' and 'http://' in the beginning of the uri that is requested to play with Sonos® own prefix 'x-rincon-mp3radio://'. This should not affect people using this method for playing other types of uris e.g. 'x-file-cifs://'.

Also the unittests are updated.

Comments/questions?

@KennethNielsen KennethNielsen force-pushed the KennethNielsen:x-rincon-mp3radio-prefix-iss434 branch from 671813e to 04fc380 Nov 2, 2016

@coveralls

This comment has been minimized.

Copy link

commented Nov 2, 2016

Coverage Status

Coverage increased (+0.04%) to 60.156% when pulling 671813e on KennethNielsen:x-rincon-mp3radio-prefix-iss434 into e17ef88 on SoCo:master.

@coveralls

This comment has been minimized.

Copy link

commented Nov 2, 2016

Coverage Status

Coverage increased (+0.04%) to 60.156% when pulling 04fc380 on KennethNielsen:x-rincon-mp3radio-prefix-iss434 into e17ef88 on SoCo:master.

@KennethNielsen

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2016

@DPH Will you review this?

@DPH

This comment has been minimized.

Copy link
Member

commented Nov 2, 2016

Will do - may take 24 hours!

On 2 November 2016 at 18:13, Kenneth Nielsen notifications@github.com
wrote:

@DPH https://github.com/DPH Will you review this?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#443 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASBqdVoj8jHsPyE-KLenA9J3e7wVNLQks5q6NLdgaJpZM4KnJV_
.

@DPH

This comment has been minimized.

Copy link
Member

commented Nov 3, 2016

Works great thanks @KennethNielsen.
Tested with a variety of streams and files, plus tested it with the snapshot function in SoCo.
All works as expected.

Good to go.
Cheers David

@KennethNielsen

This comment has been minimized.

Copy link
Member Author

commented Nov 3, 2016

Thanks @DPH. Merged.

@KennethNielsen KennethNielsen merged commit 441b6aa into SoCo:master Nov 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stefankoegl stefankoegl added this to the 0.13 milestone Nov 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.