Allow standard multicast discovery to select by household_id #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the function consistent with the behaviour of 'discover()'
pwt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resurrects and updates PR #644. It's a neat idea and avoids the requirement to use network scan discovery when multiple Sonos households are present on the network.
The PR adds an optional
household_idparameter todiscover(). If set,discover()will wait for a multicast discovery response that comes from a player in the selected household. Ifallow_network_scanisTrue, it will also use the selected household ID to filter responses.Credit to @twosky2000 for the idea and initial implementation.