Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

[WIP] set login tokens in redis with expiry #76

Closed
wants to merge 4 commits into from
Closed

[WIP] set login tokens in redis with expiry #76

wants to merge 4 commits into from

Conversation

renaynay
Copy link
Contributor

No description provided.

renaynay
renaynay commented Aug 24, 2020
View reviewed changes
pkg/api/login/endpoint.go
}

var state tokenState
if err := json.Unmarshal(rawState, &state); err != nil {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@decanus something isn't unmarshalling properly.

tried initializing state with state := new(tokenState) and also tried with state := tokenState{} and state := &tokenState{}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renaynay make the fields exported.

decanus
decanus suggested changes Aug 24, 2020
View reviewed changes
pkg/api/login/endpoint.go
@@ -292,4 +301,35 @@ func generatePin() string {
return string(b)
}

func (l *LoginEndpoint) setToken(token string, state tokenState) error {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renaynay lets move these functions into a specific backend.

@renaynay renaynay closed this Nov 2, 2020
@decanus decanus deleted the login-tokens branch February 11, 2021 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@decanus decanus decanus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@renaynay @decanus