Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove USE_TCL and USE_X_DISPLAY sections #175

Closed
garfieldnate opened this issue Jul 22, 2014 · 3 comments
Closed

remove USE_TCL and USE_X_DISPLAY sections #175

garfieldnate opened this issue Jul 22, 2014 · 3 comments

Comments

@garfieldnate
Copy link
Collaborator

The USE_TCL #define was used to turn on the usage of TCL syntax comments in the lexer, but was also used elsewhere. It may have been in oposition to USE_X_DISPLAY. I believe they are no longer relevant, and I can send a pull request to remove these, but wanted to ask whether these are really done for.

>git grep -n "USE_X_DISPLAY"
Core/SoarKernel/src/init_soar.cpp:204://#ifdef USE_X_DISPLAY
Core/SoarKernel/src/kernel.h:50://#ifdef USE_X_DISPLAY
Core/SoarKernel/src/kernel.h:77://#ifdef USE_X_DISPLAY
Core/SoarKernel/src/kernel.h:95://#endif  /* USE_X_DISPLAY */
Core/SoarKernel/src/kernel.h:145:/* #define USE_X_DISPLAY */
Core/SoarKernel/src/soarkernel.h:96://#ifdef USE_X_DISPLAY
Core/SoarKernel/src/soarkernel.h:139://#ifdef USE_X_DISPLAY
Core/SoarKernel/src/soarkernel.h:157://#endif  /* USE_X_DISPLAY */

>git grep -n "USE_TCL"
Core/ClientSMLSWIG/Tcl/SConscript:101:# clone.Append(CPPFLAGS = ['-w', '-DUSE_TC
Core/SoarKernel/src/init_soar.cpp:1133:     //     #ifdef USE_TCL
Core/SoarKernel/src/init_soar.cpp:1138:    //      #endif /* USE_TCL */
Core/SoarKernel/src/init_soar.cpp:1163:                   //                  #i
Core/SoarKernel/src/init_soar.cpp:1167:                   //                  #e
Core/SoarKernel/src/kernel.h:144:/* #ifndef USE_TCL */
Core/SoarKernel/src/kernel.h:146:/* #endif */ /* #ifndef USE_TCL */
Core/SoarKernel/src/lexer.cpp:707://#ifdef USE_TCL
Core/SoarKernel/src/lexer.cpp:753://#endif  /* USE_TCL */
Core/SoarKernel/src/print.cpp:978://#ifdef USE_TCL
Core/SoarKernel/src/print.cpp:1004://#endif /* USE_TCL */
Core/SoarKernel/src/print.cpp:1035://#ifdef USE_TCL
Core/SoarKernel/src/print.cpp:1042://#endif /* USE_TCL */
Core/SoarKernel/src/trace.cpp:772://#ifdef USE_TCL
Core/SoarKernel/src/trace.cpp:780://#endif /* USE_TCL */
Core/SoarKernel/src/trace.cpp:785://#ifdef USE_TCL
Core/SoarKernel/src/trace.cpp:789://#endif /* USE_TCL */
Core/SoarKernel/src/trace.cpp:792://#ifdef USE_TCL
Core/SoarKernel/src/trace.cpp:801://#endif /* USE_TCL */
Core/SoarKernel/src/trace.cpp:812://#ifdef USE_TCL
Core/SoarKernel/src/trace.cpp:821://#endif /* USE_TCL */
Core/SoarKernel/src/trace.cpp:842://#ifdef USE_TCL
Core/SoarKernel/src/trace.cpp:861://#endif /* USE_TCL */
Core/SoarKernel/src/trace.h:62://#ifdef USE_TCL
Core/SoarKernel/src/trace.h:64://#endif /* USE_TCL */
@marinier
Copy link
Contributor

My guess is that if these symbols aren't #define'd anywhere, then this code
can go.

Bob

On Tue, Jul 22, 2014 at 2:19 PM, garfieldnate notifications@github.com
wrote:

The USE_TCL #define was used to turn on the usage of TCL syntax comments
in the lexer, but was also used elsewhere. It may have been in oposition to
USE_X_DISPLAY. I believe they are no longer relevant, and I can send a
pull request to remove these, but wanted to ask whether these are really
done for.

git grep -n "USE_X_DISPLAY"
Core/SoarKernel/src/init_soar.cpp:204://#ifdef USE_X_DISPLAY
Core/SoarKernel/src/kernel.h:50://#ifdef USE_X_DISPLAY
Core/SoarKernel/src/kernel.h:77://#ifdef USE_X_DISPLAY
Core/SoarKernel/src/kernel.h:95://#endif /* USE_X_DISPLAY /
Core/SoarKernel/src/kernel.h:145:/ #define USE_X_DISPLAY /
Core/SoarKernel/src/soarkernel.h:96://#ifdef USE_X_DISPLAY
Core/SoarKernel/src/soarkernel.h:139://#ifdef USE_X_DISPLAY
Core/SoarKernel/src/soarkernel.h:157://#endif / USE_X_DISPLAY */

git grep -n "USE_TCL"
Core/ClientSMLSWIG/Tcl/SConscript:101:# clone.Append(CPPFLAGS = ['-w', '-DUSE_TC
Core/SoarKernel/src/init_soar.cpp:1133: // #ifdef USE_TCL
Core/SoarKernel/src/init_soar.cpp:1138: // #endif /* USE_TCL /
Core/SoarKernel/src/init_soar.cpp:1163: // #i
Core/SoarKernel/src/init_soar.cpp:1167: // #e
Core/SoarKernel/src/kernel.h:144:/ #ifndef USE_TCL /
Core/SoarKernel/src/kernel.h:146:/ #endif / / #ifndef USE_TCL /
Core/SoarKernel/src/lexer.cpp:707://#ifdef USE_TCL
Core/SoarKernel/src/lexer.cpp:753://#endif / USE_TCL /
Core/SoarKernel/src/print.cpp:978://#ifdef USE_TCL
Core/SoarKernel/src/print.cpp:1004://#endif / USE_TCL /
Core/SoarKernel/src/print.cpp:1035://#ifdef USE_TCL
Core/SoarKernel/src/print.cpp:1042://#endif / USE_TCL /
Core/SoarKernel/src/trace.cpp:772://#ifdef USE_TCL
Core/SoarKernel/src/trace.cpp:780://#endif / USE_TCL /
Core/SoarKernel/src/trace.cpp:785://#ifdef USE_TCL
Core/SoarKernel/src/trace.cpp:789://#endif / USE_TCL /
Core/SoarKernel/src/trace.cpp:792://#ifdef USE_TCL
Core/SoarKernel/src/trace.cpp:801://#endif / USE_TCL /
Core/SoarKernel/src/trace.cpp:812://#ifdef USE_TCL
Core/SoarKernel/src/trace.cpp:821://#endif / USE_TCL /
Core/SoarKernel/src/trace.cpp:842://#ifdef USE_TCL
Core/SoarKernel/src/trace.cpp:861://#endif / USE_TCL /
Core/SoarKernel/src/trace.h:62://#ifdef USE_TCL
Core/SoarKernel/src/trace.h:64://#endif / USE_TCL */

—
Reply to this email directly or view it on GitHub
#175.

@mazina
Copy link
Contributor

mazina commented Jul 22, 2014

fyi, they're already removed in 9.5. Some may be gone in 9.4 as well.

On Tuesday, July 22, 2014, marinier notifications@github.com wrote:

My guess is that if these symbols aren't #define'd anywhere, then this
code
can go.

Bob

On Tue, Jul 22, 2014 at 2:19 PM, garfieldnate <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');>
wrote:

The USE_TCL #define was used to turn on the usage of TCL syntax comments
in the lexer, but was also used elsewhere. It may have been in oposition
to
USE_X_DISPLAY. I believe they are no longer relevant, and I can send a
pull request to remove these, but wanted to ask whether these are really
done for.

git grep -n "USE_X_DISPLAY"
Core/SoarKernel/src/init_soar.cpp:204://#ifdef USE_X_DISPLAY
Core/SoarKernel/src/kernel.h:50://#ifdef USE_X_DISPLAY
Core/SoarKernel/src/kernel.h:77://#ifdef USE_X_DISPLAY
Core/SoarKernel/src/kernel.h:95://#endif /* USE_X_DISPLAY /
Core/SoarKernel/src/kernel.h:145:/ #define USE_X_DISPLAY /
Core/SoarKernel/src/soarkernel.h:96://#ifdef USE_X_DISPLAY
Core/SoarKernel/src/soarkernel.h:139://#ifdef USE_X_DISPLAY
Core/SoarKernel/src/soarkernel.h:157://#endif / USE_X_DISPLAY */

git grep -n "USE_TCL"
Core/ClientSMLSWIG/Tcl/SConscript:101:# clone.Append(CPPFLAGS = ['-w',
'-DUSE_TC
Core/SoarKernel/src/init_soar.cpp:1133: // #ifdef USE_TCL
Core/SoarKernel/src/init_soar.cpp:1138: // #endif /* USE_TCL /
Core/SoarKernel/src/init_soar.cpp:1163: // #i
Core/SoarKernel/src/init_soar.cpp:1167: // #e
Core/SoarKernel/src/kernel.h:144:/ #ifndef USE_TCL /
Core/SoarKernel/src/kernel.h:146:/ #endif / / #ifndef USE_TCL /
Core/SoarKernel/src/lexer.cpp:707://#ifdef USE_TCL
Core/SoarKernel/src/lexer.cpp:753://#endif / USE_TCL /
Core/SoarKernel/src/print.cpp:978://#ifdef USE_TCL
Core/SoarKernel/src/print.cpp:1004://#endif / USE_TCL /
Core/SoarKernel/src/print.cpp:1035://#ifdef USE_TCL
Core/SoarKernel/src/print.cpp:1042://#endif / USE_TCL /
Core/SoarKernel/src/trace.cpp:772://#ifdef USE_TCL
Core/SoarKernel/src/trace.cpp:780://#endif / USE_TCL /
Core/SoarKernel/src/trace.cpp:785://#ifdef USE_TCL
Core/SoarKernel/src/trace.cpp:789://#endif / USE_TCL /
Core/SoarKernel/src/trace.cpp:792://#ifdef USE_TCL
Core/SoarKernel/src/trace.cpp:801://#endif / USE_TCL /
Core/SoarKernel/src/trace.cpp:812://#ifdef USE_TCL
Core/SoarKernel/src/trace.cpp:821://#endif / USE_TCL /
Core/SoarKernel/src/trace.cpp:842://#ifdef USE_TCL
Core/SoarKernel/src/trace.cpp:861://#endif / USE_TCL /
Core/SoarKernel/src/trace.h:62://#ifdef USE_TCL
Core/SoarKernel/src/trace.h:64://#endif / USE_TCL */

—
Reply to this email directly or view it on GitHub
#175.

—
Reply to this email directly or view it on GitHub
#175 (comment).

@garfieldnate
Copy link
Collaborator Author

Ah, should have checked.

@garfieldnate garfieldnate mentioned this issue Aug 12, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marinier @garfieldnate @mazina