Throw for bad param in GetParameterValue #465
Open
+121
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behavior here was to segfault! An exception is much more user-friendly. Add the SWIG machinery for catching thrown exceptions in the SML binding libraries, too. We wrap every SML function with a try/catch. I don't know if this is actually heavy or not, but at least one implementation out there thought it was and went an alternative route where each method has to be explicitly marked to catch exceptions: https://github.com/KiCad/kicad-source-mirror/blob/47e4ebb32a1366d60649879381eac819f7c7131d/common/swig/ki_exception.i#L41 Add tests for TCL, Python and Java that demonstrate the exceptions being translated for each host language. We don't have C# tests yet T_T. Notice we did have to add the `atexit` handler back to prevent a segfault when the exception is not caught correctly; I don't know exactly why. Filed #464. Fixes #451.
| SWIG_exception(SWIG_RuntimeError, e.what()); | ||
| } | ||
| catch(...) { | ||
| SWIG_exception(SWIG_RuntimeError, "Unknown exception"); |
There was a problem hiding this comment.
We should still maybe append the exception type / value / string to give at least some information to the developer, imo.
| @@ -31,40 +31,40 @@ namespace sml | |||
| class StringElement ; | |||
| class WorkingMemory ; | |||
| class Identifier ; | |||
|
|
|||
There was a problem hiding this comment.
A lot of these whitespace changes btw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior here was to segfault! An exception is much more user-friendly.
Add the SWIG machinery for catching thrown exceptions in the SML binding libraries, too. We wrap every SML function with a try/catch. I don't know if this is actually heavy or not, but at least one implementation out there thought it was and went an alternative route where each method has to be explicitly marked to catch exceptions:
https://github.com/KiCad/kicad-source-mirror/blob/47e4ebb32a1366d60649879381eac819f7c7131d/common/swig/ki_exception.i#L41
Add tests for TCL, Python and Java that demonstrate the exceptions being translated for each host language. We don't have C# tests yet T_T.
Notice we did have to add the
atexithandler back to prevent a segfault when the exception is not caught correctly; I don't know exactly why. Filed #464.Fixes #451.