remove the full stack zf2 dependency #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabiocarneiro - are you using this on a site that isn't ZF2? I'm not really familiar with this module, it was actually developed by some users of https://github.com/SocalNick/ScnSocialAuth as an add-on. |
|
Hi there, i haven't tested it but i like the idea of limiting the dependencies only to what is actually required. Same goes for SocalNick/ScnSocialAuthDoctrineMongoODM#2 |
|
@SocalNick I'm using this in a zf2 project, but its not a good idea to rely in the entire project. It conflicts with projects that require an specific version. It will be even more important after zf2 split. |
SocalNick
added a commit
that referenced
this pull request
Apr 18, 2015
remove the full stack zf2 dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.